Merge pull request #213 from jdufresne/resource-warnings

Fix all "ResourceWarning: unclosed file ..." warnings during tests

src/icalendar/tests/apple_xlocation_test.py

@@ -14,7 +14,8 @@ class TestEncoding(unittest.TestCase):
         """
         try:
             directory = os.path.dirname(__file__)
-            data = open(os.path.join(directory, 'x_location.ics'), 'rb').read()
+            with open(os.path.join(directory, 'x_location.ics'), 'rb') as fp:
+                data = fp.read()
             cal = icalendar.Calendar.from_ical(data)
             for event in cal.walk('vevent'):
                 self.assertEqual(len(event.errors), 1, 'Got too many errors')

src/icalendar/tests/test_encoding.py

@@ -11,7 +11,8 @@ class TestEncoding(unittest.TestCase):
 
     def test_create_from_ical(self):
         directory = os.path.dirname(__file__)
-        data = open(os.path.join(directory, 'encoding.ics'), 'rb').read()
+        with open(os.path.join(directory, 'encoding.ics'), 'rb') as fp:
+            data = fp.read()
         cal = icalendar.Calendar.from_ical(data)
 
         self.assertEqual(cal['prodid'].to_ical().decode('utf-8'),

src/icalendar/tests/test_multiple.py

@@ -12,10 +12,9 @@ class TestMultiple(unittest.TestCase):
     def test_multiple(self):
 
         directory = os.path.dirname(__file__)
-        cals = Calendar.from_ical(
+        with open(os.path.join(directory, 'multiple.ics'), 'rb') as fp:
-            open(os.path.join(directory, 'multiple.ics'), 'rb').read(),
+            data = fp.read()
-            multiple=True
+        cals = Calendar.from_ical(data, multiple=True)
-        )
 
         self.assertEqual(len(cals), 2)
         self.assertSequenceEqual([comp.name for comp in cals[0].walk()],

src/icalendar/tests/test_recurrence.py

@@ -12,9 +12,9 @@ class TestRecurrence(unittest.TestCase):
 
     def setUp(self):
         directory = os.path.dirname(__file__)
-        self.cal = icalendar.Calendar.from_ical(
+        with open(os.path.join(directory, 'recurrence.ics'), 'rb') as fp:
-            open(os.path.join(directory, 'recurrence.ics'), 'rb').read()
+            data = fp.read()
-        )
+        self.cal = icalendar.Calendar.from_ical(data)
 
     def test_recurrence_exdates_one_line(self):
         first_event = self.cal.walk('vevent')[0]

src/icalendar/tests/test_timezoned.py

@@ -12,9 +12,9 @@ class TestTimezoned(unittest.TestCase):
 
     def test_create_from_ical(self):
         directory = os.path.dirname(__file__)
-        cal = icalendar.Calendar.from_ical(
+        with open(os.path.join(directory, 'timezoned.ics'), 'rb') as fp:
-            open(os.path.join(directory, 'timezoned.ics'), 'rb').read()
+            data = fp.read()
-        )
+        cal = icalendar.Calendar.from_ical(data)
 
         self.assertEqual(
             cal['prodid'].to_ical(),
@@ -151,9 +151,9 @@ class TestTimezoneCreation(unittest.TestCase):
         RFC"""
 
         directory = os.path.dirname(__file__)
-        cal = icalendar.Calendar.from_ical(
+        with open(os.path.join(directory, 'america_new_york.ics'), 'rb') as fp:
-            open(os.path.join(directory, 'america_new_york.ics'), 'rb').read()
+            data = fp.read()
-        )
+        cal = icalendar.Calendar.from_ical(data)
 
         tz = cal.walk('VEVENT')[0]['DTSTART'][0].dt.tzinfo
         self.assertEqual(str(tz), 'custom_America/New_York')
@@ -188,9 +188,9 @@ class TestTimezoneCreation(unittest.TestCase):
         self.maxDiff = None
 
         directory = os.path.dirname(__file__)
-        cal = icalendar.Calendar.from_ical(
+        with open(os.path.join(directory, 'pacific_fiji.ics'), 'rb') as fp:
-            open(os.path.join(directory, 'pacific_fiji.ics'), 'rb').read()
+            data = fp.read()
-        )
+        cal = icalendar.Calendar.from_ical(data)
 
         tz = cal.walk('VEVENT')[0]['DTSTART'][0].dt.tzinfo
         self.assertEqual(str(tz), 'custom_Pacific/Fiji')

src/icalendar/tests/test_unit_cal.py

@@ -393,7 +393,8 @@ class TestCal(unittest.TestCase):
         import tempfile
         import os
         directory = tempfile.mkdtemp()
-        open(os.path.join(directory, 'test.ics'), 'wb').write(cal.to_ical())
+        with open(os.path.join(directory, 'test.ics'), 'wb') as fp:
+            fp.write(cal.to_ical())
 
         # Parsing a complete calendar from a string will silently ignore wrong
         # events but adding the error information to the component's 'errors'