mirror
/
icalendar
kopia lustrzana https://github.com/collective/icalendar
1
0
Forkuj 0
Kod Zgłoszenia Packages Projekty Wydania Wiki Aktywność

Make coverage report optional in case it fails to submit (#664) 

* Make coverage report optional in case it fails to submit

Sometimes, we get this error:
coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs

This PR allows the error to happen while also maintaining the test
result and making sure that we actually installed all dependencies.

This is a follow up from
https://github.com/collective/icalendar/pull/644
main branch failed:
https://github.com/collective/icalendar/actions/runs/9663149658/job/26654629821

* log changes

* use github service for coverage

* Finalize coverage even if tests failed

---------

Co-authored-by: Steve Piercy <web@stevepiercy.com>
pull/674/head^2
Nicco Kunzmann 2024-07-01 22:11:47 +01:00 zatwierdzone przez GitHub
rodzic 1996b0be32
commit 4e218edacd
Nie znaleziono w bazie danych klucza dla tego podpisu
ID klucza GPG: B5690EEEBB952194
2 zmienionych plików z 6 dodań i 2 usunięć
Pokaż statystyki Ściągnij plik aktualizacji Ściągnij plik porównania Expand all files Collapse all files

7
.github/workflows/tests.yml vendored
Wyświetl plik

@ -48,7 +48,7 @@ jobs:
- name: Test - name: Test
run: tox -e ${{ matrix.config[1] }} run: tox -e ${{ matrix.config[1] }}
- name: Upload coverage data to coveralls.io - name: Upload coverage data to coveralls.io
run: coveralls --service=github-actions run: coveralls --service=github || which coveralls
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_REPO_TOKEN: ${{ secrets.CODECOV_TOKEN }} COVERALLS_REPO_TOKEN: ${{ secrets.CODECOV_TOKEN }}
@ -60,13 +60,16 @@ jobs:
# see https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support # see https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html#github-actions-support
name: Submit test coverage name: Submit test coverage
needs: run-tests needs: run-tests
# always finalize coverage aftest tests ran
# see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-not-requiring-successful-dependent-jobs
if: ${{ always() }}
runs-on: ubuntu-latest runs-on: ubuntu-latest
container: python:3-slim container: python:3-slim
steps: steps:
- name: Install dependencies - name: Install dependencies
run: pip3 install --upgrade coveralls run: pip3 install --upgrade coveralls
- name: Upload coverage - name: Upload coverage
run: coveralls --service=github-actions --finish run: coveralls --service=github --finish || which coveralls
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
COVERALLS_REPO_TOKEN: ${{ secrets.CODECOV_TOKEN }} COVERALLS_REPO_TOKEN: ${{ secrets.CODECOV_TOKEN }}

1
CHANGES.rst
Wyświetl plik

@ -8,6 +8,7 @@ Minor changes:
- Test that all code works with both ``pytz`` and ``zoneinfo``. - Test that all code works with both ``pytz`` and ``zoneinfo``.
- Make coverage report submission optional for pull requests - Make coverage report submission optional for pull requests
- Parallelize coverage
- Rename ``master`` branch to ``main``, see `Issue - Rename ``master`` branch to ``main``, see `Issue
<https://github.com/collective/icalendar/issues/627>`_ <https://github.com/collective/icalendar/issues/627>`_
- Added missing public classes and functions to API documentation. - Added missing public classes and functions to API documentation.