From 33f5cec18bf60af323a33a1d6bc05bd132731295 Mon Sep 17 00:00:00 2001
From: John Greb <hexameron>
Date: Tue, 11 Aug 2015 19:27:53 +0100
Subject: [PATCH] More robust testing.

---
 src/UKHASExtractor.cxx  | 2 ++
 tests/test_extractor.py | 7 ++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/UKHASExtractor.cxx b/src/UKHASExtractor.cxx
index 8864524..a1c6be4 100644
--- a/src/UKHASExtractor.cxx
+++ b/src/UKHASExtractor.cxx
@@ -270,6 +270,8 @@ static string convert_ddmmmm(const string &value)
     if (right_val >= 60 || right_val < 0)
         throw runtime_error("invalid right part (ddmm)");
 
+    if (value.find('-') != string::npos)
+        right_val *= -1;
     double dd = left_val + (right_val / 60);
     
     ostringstream os;
diff --git a/tests/test_extractor.py b/tests/test_extractor.py
index 4504e34..5c9e949 100644
--- a/tests/test_extractor.py
+++ b/tests/test_extractor.py
@@ -363,6 +363,10 @@ class TestUKHASExtractor:
                  "format":"dd.dddd"},
                 {"sensor":"stdtelem.coordinate","name":"lat_b",
                  "format":"ddmm.mm"},
+		{"sensor":"stdtelem.coordinate","name":"lat_a_neg",
+		 "format":"ddmm.mm"},
+		{"sensor":"stdtelem.coordinate","name":"lat_b_neg",
+		 "format":"ddmm.mm"},
                 {"name": "field_b"}
             ],
         } ]
@@ -370,7 +374,7 @@ class TestUKHASExtractor:
 
     def test_ddmmmmmm(self):
         self.extr.set_current_payload(self.ddmmmmmm_flight_doc)
-        string = "$$TESTING,0024.124583,5116.5271,whatever*14BA\n"
+        string = "$$TESTING,0024.124583,5116.5271,-0016.5271,-5116.5271,whatever*F390\n"
         self.extr.push(string)
         self.extr.check_status("start delim")
         self.extr.check_upload(string)
@@ -378,6 +382,7 @@ class TestUKHASExtractor:
         self.extr.check_data({"_sentence": string, "_parsed": True,
                               "_protocol": "UKHAS", "payload": "TESTING",
                               "lat_a": "0024.124583", "lat_b": "51.27545",
+                              "lat_a_neg": "-0.27545", "lat_b_neg": "-51.27545",
                               "field_b": "whatever" })
 
     numeric_scale_flight_doc = {