From 1d2b309e281fcc86d22e8104ca0509fa2959a3d5 Mon Sep 17 00:00:00 2001
From: Sebastian Delmont <sd@notso.net>
Date: Mon, 26 Oct 2020 09:56:19 -0400
Subject: [PATCH] Make UDP port validations clearer, allow receive port to be
 2238 if forwarding is not enabled, and only use port after it's been
 validated

---
 package.nw/GridTracker.html |  6 +++---
 package.nw/lib/gt.js        | 31 ++++++++++++++++---------------
 2 files changed, 19 insertions(+), 18 deletions(-)

diff --git a/package.nw/GridTracker.html b/package.nw/GridTracker.html
index 821997d..c7bb6e3 100644
--- a/package.nw/GridTracker.html
+++ b/package.nw/GridTracker.html
@@ -419,7 +419,7 @@
                            <td id="multicastTD" style="display:none" >IP <input id="multicastIpInput" type="text" class="inputTextValue"  maxlength="15"  size="10" onkeypress='return validIpKeys(event.charCode);' oninput=" if ( ValidateMulticast(this) ) setMulticastIp();   "/></td>
                         </tr>
                         <tr>
-                           <td>Port <input id="udpPortInput" type="text" class="inputTextValue"  maxlength="5" size="5" onkeypress='return validNumberKeys(event.charCode);' oninput="if ( ValidatePort(this,null, CheckNotRemoteIpPort ) ) setUdpPort();" /></td>
+                           <td>Port <input id="udpPortInput" type="text" class="inputTextValue"  maxlength="5" size="5" onkeypress='return validNumberKeys(event.charCode);' oninput="if ( ValidatePort(this, null, CheckReceivePortIsNotForwardPort) ) setUdpPort();" /></td>
                         </tr>
                      </table>
                   </div>
@@ -434,10 +434,10 @@
                            <td ><i>e.g. GridTracker on another host</i></td>
                         </tr>
                         <tr>
-                           <td >IP <input id="udpForwardIpInput" type="text" class="inputTextValue"  maxlength="15"  size="10" onkeypress='return validIpKeys(event.charCode);' oninput=" if ( ValidateIPaddress(this,udpForwardEnable) ) setForwardIp();   "/></td>
+                           <td >IP <input id="udpForwardIpInput" type="text" class="inputTextValue"  maxlength="15"  size="10" onkeypress='return validIpKeys(event.charCode);' oninput=" if ( ValidateIPaddress(this, udpForwardEnable) ) setForwardIp();   "/></td>
                         </tr>
                         <tr>
-                           <td >Port <input id="udpForwardPortInput" type="text" class="inputTextValue"   maxlength="5" size="5" onkeypress='return validNumberKeys(event.charCode);' oninput="if ( ValidatePort(this,udpForwardEnable, CheckNotLocalPort ) )  setForwardPort();  " /></td>
+                           <td >Port <input id="udpForwardPortInput" type="text" class="inputTextValue"   maxlength="5" size="5" onkeypress='return validNumberKeys(event.charCode);' oninput="if ( ValidatePort(this, udpForwardEnable, CheckForwardPortIsNotReceivePort) )  setForwardPort();  " /></td>
                         </tr>
                         <tr>
                            <td> Enabled?<input title="Enable / Disable UDP Message forwarding" type="checkbox"  id="udpForwardEnable" onclick="setUdpForwardEnable(this);" /></td>
diff --git a/package.nw/lib/gt.js b/package.nw/lib/gt.js
index 0dc94db..645b0c8 100644
--- a/package.nw/lib/gt.js
+++ b/package.nw/lib/gt.js
@@ -9110,7 +9110,7 @@ function setMulticastEnable(checkbox) {
 
 function setUdpForwardEnable(checkbox) {
 	if (checkbox.checked) {
-		if (ValidatePort(udpForwardPortInput, null, CheckNotLocalPort) && ValidateIPaddress(udpForwardIpInput,
+		if (ValidatePort(udpForwardPortInput, null, CheckForwardPortIsNotReceivePort) && ValidateIPaddress(udpForwardIpInput,
 				null)) {
 			g_appSettings.wsjtForwardUdpEnable = checkbox.checked;
 			return;
@@ -9502,30 +9502,31 @@ function updateBasedOnIni() {
 	}
 }
 
-function CheckNotRemoteIpPort(value) {
-	if (udpForwardIpInput.value == "127.0.0.1" && udpForwardPortInput.value == value && g_appSettings.wsjtIP == "")
-		return true;
-	return false;
+function CheckReceivePortIsNotForwardPort(value) {
+	if (udpForwardIpInput.value == "127.0.0.1" && udpForwardPortInput.value == value && g_appSettings.wsjtIP == "" && udpForwardEnable.checked) {
+		return false;
+	}
+	return true;
 }
 
-function CheckNotLocalPort(value) {
+function CheckForwardPortIsNotReceivePort(value) {
 	if (udpForwardIpInput.value == "127.0.0.1" && udpPortInput.value == value && g_appSettings.wsjtIP == "")
-		return true;
-	return false;
+		return false;
+	return true;
 }
 
 function setForwardIp() {
 	g_appSettings.wsjtForwardUdpIp = udpForwardIpInput.value;
-	if (ValidatePort(udpPortInput, null, CheckNotRemoteIpPort)) {
+	if (ValidatePort(udpPortInput, null, CheckReceivePortIsNotForwardPort)) {
 		setUdpPort();
 	}
-	ValidatePort(udpForwardPortInput, null, CheckNotLocalPort);
+	ValidatePort(udpForwardPortInput, null, CheckForwardPortIsNotReceivePort);
 }
 
 function setForwardPort() {
 	g_appSettings.wsjtForwardUdpPort = udpForwardPortInput.value;
 	ValidateIPaddress(udpForwardIpInput, null);
-	if (ValidatePort(udpPortInput, null, CheckNotRemoteIpPort)) {
+	if (ValidatePort(udpPortInput, null, CheckReceivePortIsNotForwardPort)) {
 		setUdpPort();
 	}
 }
@@ -9792,7 +9793,7 @@ function ValidateIPaddress(inputText, checkBox) {
 function ValidatePort(inputText, checkBox, callBackCheck) {
 	var value = Number(inputText.value);
 	if (value > 1023 && value < 65536) {
-		if (callBackCheck && callBackCheck(value)) {
+		if (callBackCheck && !callBackCheck(value)) {
 			inputText.style.color = "#FFF";
 			inputText.style.backgroundColor = "red";
 			if (checkBox)
@@ -11399,9 +11400,9 @@ function loadPortSettings()
 	multicastIpInput.value = g_appSettings.wsjtIP;
 	setMulticastEnable(multicastEnable);
 	udpPortInput.value = g_appSettings.wsjtUdpPort;
-	ValidatePort(udpPortInput, null, CheckNotRemoteIpPort);
+	ValidatePort(udpPortInput, null, CheckReceivePortIsNotForwardPort);
 	udpForwardPortInput.value = g_appSettings.wsjtForwardUdpPort;
-	ValidatePort(udpForwardPortInput, null, CheckNotLocalPort);
+	ValidatePort(udpForwardPortInput, null, CheckForwardPortIsNotReceivePort);
 	udpForwardIpInput.value = g_appSettings.wsjtForwardUdpIp;
 	ValidateIPaddress(udpForwardIpInput, null);
 	udpForwardEnable.checked = g_appSettings.wsjtForwardUdpEnable;
@@ -11563,7 +11564,7 @@ function checkWsjtxListener() {
 		g_wsjtCurrentPort = -1;
 		g_wsjtCurrentIP = "none";
 	}
-	updateWsjtxListener(udpPortInput.value);
+	updateWsjtxListener(g_appSettings.wsjtUdpPort);
 }
 
 var g_instances = {};