diff --git a/changes/changelog.d/use-logger.enchancement b/changes/changelog.d/use-logger.enchancement new file mode 100644 index 000000000..afc450ba8 --- /dev/null +++ b/changes/changelog.d/use-logger.enchancement @@ -0,0 +1 @@ +Use logger composable instead of window.console diff --git a/front/.eslintrc.js b/front/.eslintrc.js index c9ea0eb18..6a2ecc376 100644 --- a/front/.eslintrc.js +++ b/front/.eslintrc.js @@ -26,6 +26,9 @@ module.exports = { // NOTE: Nicer for the eye 'operator-linebreak': ['error', 'before'], + // NOTE: We have a logger instance + 'no-console': 'error', + // NOTE: Handled by typescript '@typescript-eslint/no-unused-vars': 'off', 'no-use-before-define': 'off', diff --git a/front/package.json b/front/package.json index 24fc09dcf..fbb5f8438 100644 --- a/front/package.json +++ b/front/package.json @@ -34,7 +34,6 @@ "fomantic-ui-css": "2.9.2", "howler": "2.2.3", "idb-keyval": "6.2.1", - "js-logger": "1.6.1", "lodash-es": "4.17.21", "lru-cache": "7.14.1", "moment": "2.29.4", diff --git a/front/src/components/favorites/List.vue b/front/src/components/favorites/List.vue index cd6a7f540..1c917fc6e 100644 --- a/front/src/components/favorites/List.vue +++ b/front/src/components/favorites/List.vue @@ -64,8 +64,8 @@ const fetchFavorites = async () => { ordering: orderingString.value } + const stop = logger.time('Loading user favorites') try { - const stop = logger.time('Loading user favorites') const response = await axios.get('tracks/', { params }) results.length = 0 diff --git a/front/src/composables/useLogger.ts b/front/src/composables/useLogger.ts index e6d3942e6..169bc7867 100644 --- a/front/src/composables/useLogger.ts +++ b/front/src/composables/useLogger.ts @@ -1,15 +1,3 @@ -// import Logger from 'js-logger' -// -// Logger.useDefaults({ -// defaultLevel: import.meta.env.DEV -// ? Logger.DEBUG -// : Logger.WARN -// }) -// -// export default (logger?: string) => logger -// ? Logger.get(logger) -// : Logger - type LogLevel = 'info' | 'warn' | 'error' | 'debug' | 'time' const LOG_LEVEL_LABELS: Record = { @@ -75,6 +63,7 @@ const createLoggerFn = (level: LogLevel) => { if (import.meta.env.PROD) return } + // eslint-disable-next-line no-console console[level === 'time' ? 'debug' : level]( '%c %c [%s] %c %s %c%s', `background: ${LOG_LEVEL_BACKGROUND[level]};border-radius:1em`, diff --git a/front/yarn.lock b/front/yarn.lock index 300baf3dc..09d25409c 100644 --- a/front/yarn.lock +++ b/front/yarn.lock @@ -4334,11 +4334,6 @@ jquery@^3.4.0: resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.7.0.tgz#fe2c01a05da500709006d8790fe21c8a39d75612" integrity sha512-umpJ0/k8X0MvD1ds0P9SfowREz2LenHsQaxSohMZ5OMNEU2r0tf8pdeEFTHMFxWVxKNyU9rTtK3CWzUCTKJUeQ== -js-logger@1.6.1: - version "1.6.1" - resolved "https://registry.yarnpkg.com/js-logger/-/js-logger-1.6.1.tgz#8f09671b515e4a6f31dced8fdb8923432e2c60af" - integrity sha512-yTgMCPXVjhmg28CuUH8CKjU+cIKL/G+zTu4Fn4lQxs8mRFH/03QTNvEFngcxfg/gRDiQAOoyCKmMTOm9ayOzXA== - js-sdsl@^4.1.4: version "4.4.1" resolved "https://registry.yarnpkg.com/js-sdsl/-/js-sdsl-4.4.1.tgz#9e3c7b566d8d9a7e1fe8fc26d00b5ab0f8918ab3"