From 66c8e7a9e4b1568e6668f233f920c417ff113923 Mon Sep 17 00:00:00 2001
From: Eliot Berriot <contact@eliotberriot.com>
Date: Sat, 3 Nov 2018 23:07:47 +0100
Subject: [PATCH] Fix #597: Ensure admin links in sidebar are displayed for
 users with relavant permissions, and only them

---
 changes/changelog.d/597.bugfix   |  1 +
 front/src/components/Sidebar.vue | 21 +--------------------
 front/src/store/auth.js          |  8 +++++++-
 3 files changed, 9 insertions(+), 21 deletions(-)
 create mode 100644 changes/changelog.d/597.bugfix

diff --git a/changes/changelog.d/597.bugfix b/changes/changelog.d/597.bugfix
new file mode 100644
index 000000000..d12951322
--- /dev/null
+++ b/changes/changelog.d/597.bugfix
@@ -0,0 +1 @@
+Ensure admin links in sidebar are displayed for users with relavant permissions, and only them (#597)
diff --git a/front/src/components/Sidebar.vue b/front/src/components/Sidebar.vue
index 449238c2e..44813c6c9 100644
--- a/front/src/components/Sidebar.vue
+++ b/front/src/components/Sidebar.vue
@@ -76,18 +76,16 @@
               class="item" :to="{name: 'content.index'}"><i class="upload icon"></i><translate>Add content</translate></router-link>
           </div>
         </div>
-        <div class="item" v-if="showAdmin">
+        <div class="item" v-if="$store.state.auth.availablePermissions['settings']">
           <div class="header"><translate>Administration</translate></div>
           <div class="menu">
             <router-link
               class="item"
-              v-if="$store.state.auth.availablePermissions['settings']"
               :to="{path: '/manage/settings'}">
               <i class="settings icon"></i><translate>Settings</translate>
             </router-link>
             <router-link
               class="item"
-              v-if="$store.state.auth.availablePermissions['settings']"
               :to="{name: 'manage.users.users.list'}">
               <i class="users icon"></i><translate>Users</translate>
             </router-link>
@@ -184,7 +182,6 @@ export default {
       tracksChangeBuffer: null,
       isCollapsed: true,
       fetchInterval: null,
-      showAdmin: this.getShowAdmin()
     }
   },
   mounted () {
@@ -228,16 +225,6 @@ export default {
     ...mapActions({
       cleanTrack: 'queue/cleanTrack'
     }),
-    getShowAdmin () {
-      let adminPermissions = [
-        this.$store.state.auth.availablePermissions['federation'],
-        this.$store.state.auth.availablePermissions['library'],
-        this.$store.state.auth.availablePermissions['upload']
-      ]
-      return adminPermissions.filter(e => {
-        return e
-      }).length > 0
-    },
     reorder: function (event) {
       this.$store.commit('queue/reorder', {
         tracks: this.tracksChangeBuffer, oldIndex: event.oldIndex, newIndex: event.newIndex})
@@ -271,12 +258,6 @@ export default {
         this.scrollToCurrent()
       }
     },
-    '$store.state.auth.availablePermissions': {
-      handler () {
-        this.showAdmin = this.getShowAdmin()
-      },
-      deep: true
-    }
   }
 }
 </script>
diff --git a/front/src/store/auth.js b/front/src/store/auth.js
index 4100981bb..7551f4449 100644
--- a/front/src/store/auth.js
+++ b/front/src/store/auth.js
@@ -8,7 +8,12 @@ export default {
   state: {
     authenticated: false,
     username: '',
-    availablePermissions: {},
+    availablePermissions: {
+      federation: false,
+      settings: false,
+      library: false,
+      upload: false
+    },
     profile: null,
     token: '',
     tokenData: {}
@@ -27,6 +32,7 @@ export default {
       state.tokenData = {}
       state.availablePermissions = {
         federation: false,
+        settings: false,
         library: false,
         upload: false
       }