Merge branch 'auto-hostname' into 'develop'

Removed the need to specify the DJANGO_ALLOWED_HOSTS variable

See merge request funkwhale/funkwhale!478

.gitlab-ci.yml

@@ -140,7 +140,6 @@ test_api:
     paths:
       - "$PIP_CACHE_DIR"
   variables:
-    DJANGO_ALLOWED_HOSTS: "localhost"
     DATABASE_URL: "postgresql://postgres@postgres/postgres"
     FUNKWHALE_URL: "https://funkwhale.ci"
     DJANGO_SETTINGS_MODULE: config.settings.local

api/config/settings/common.py

@@ -60,7 +60,7 @@ FEDERATION_MUSIC_NEEDS_APPROVAL = env.bool(
 )
 # XXX: deprecated, see #186
 FEDERATION_ACTOR_FETCH_DELAY = env.int("FEDERATION_ACTOR_FETCH_DELAY", default=60 * 12)
-ALLOWED_HOSTS = env.list("DJANGO_ALLOWED_HOSTS")
+ALLOWED_HOSTS = env.list("DJANGO_ALLOWED_HOSTS", default=[]) + [FUNKWHALE_HOSTNAME]
 
 # APP CONFIGURATION
 # ------------------------------------------------------------------------------

changes/changelog.d/allowed-hosts.enhancement

@@ -0,0 +1 @@
+Removed the need to specify the DJANGO_ALLOWED_HOSTS variable

demo/env.sample

@@ -1,5 +1,4 @@
 FUNKWHALE_URL=https://demo.funkwhale.audio/
-DJANGO_ALLOWED_HOSTS=demo.funkwhale.audio
 FUNKWHALE_API_PORT=5001
 DJANGO_SECRET_KEY=demo
 DATABASE_URL=postgresql://postgres@postgres/postgres

deploy/env.prod.sample

@@ -4,7 +4,6 @@
 # If you're tweaking this file from the template, ensure you edit at least the
 # following variables:
 # - DJANGO_SECRET_KEY
-# - DJANGO_ALLOWED_HOSTS
 # - FUNKWHALE_HOSTNAME
 # - EMAIL_CONFIG and DEFAULT_FROM_EMAIL if you plan to send emails)
 # On non-docker setup **only**, you'll also have to tweak/uncomment those variables:
@@ -85,11 +84,6 @@ MEDIA_ROOT=/srv/funkwhale/data/media
 # (Ensure this directory actually exists)
 STATIC_ROOT=/srv/funkwhale/data/static
 
-# Update it to match the domain that will be used to reach your funkwhale
-# instance
-# Example: DJANGO_ALLOWED_HOSTS=funkwhale.yourdomain.com
-DJANGO_ALLOWED_HOSTS=yourdomain
-
 # which settings module should django use?
 # You don't have to touch this unless you really know what you're doing
 DJANGO_SETTINGS_MODULE=config.settings.production