From 097f803faba58f5a8fc02050dec0b6e1997d7499 Mon Sep 17 00:00:00 2001 From: Philipp Wolfer Date: Fri, 20 Jan 2023 13:35:13 +0100 Subject: [PATCH] Docker: Do not publicly expose API port The default docker-setup exposes the API container directly on port 5000. This should not be the case and is not needed, as API access is all routed through the frontend nginx reverse proxy. Part-of: --- changes/changelog.d/docker-public-port.bugfix | 1 + deploy/docker-compose.yml | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) create mode 100644 changes/changelog.d/docker-public-port.bugfix diff --git a/changes/changelog.d/docker-public-port.bugfix b/changes/changelog.d/docker-public-port.bugfix new file mode 100644 index 000000000..063afde05 --- /dev/null +++ b/changes/changelog.d/docker-public-port.bugfix @@ -0,0 +1 @@ +Docker setup: do not export the API port 5000 publicly diff --git a/deploy/docker-compose.yml b/deploy/docker-compose.yml index 0ecf3c670..4ad645fd1 100644 --- a/deploy/docker-compose.yml +++ b/deploy/docker-compose.yml @@ -59,8 +59,6 @@ services: - "${MUSIC_DIRECTORY_SERVE_PATH-/srv/funkwhale/data/music}:${MUSIC_DIRECTORY_PATH-/music}:ro" - "${MEDIA_ROOT}:${MEDIA_ROOT}" - "${STATIC_ROOT}:${STATIC_ROOT}" - ports: - - "5000" front: restart: unless-stopped