From 2a3e235f9ac87474d673981bc5cd01bef1168cdc Mon Sep 17 00:00:00 2001
From: rabuzarus <>
Date: Wed, 5 Oct 2016 14:45:19 +0200
Subject: [PATCH] show/hide page-flags according to the account-type

---
 mod/settings.php                      |  2 +-
 view/global.css                       |  5 ++
 view/templates/pagetypes.tpl          | 26 ----------
 view/templates/settings_pagetypes.tpl | 71 +++++++++++++++++++++++++++
 4 files changed, 77 insertions(+), 27 deletions(-)
 delete mode 100644 view/templates/pagetypes.tpl
 create mode 100644 view/templates/settings_pagetypes.tpl

diff --git a/mod/settings.php b/mod/settings.php
index 908d828456..37498a0dda 100644
--- a/mod/settings.php
+++ b/mod/settings.php
@@ -1083,7 +1083,7 @@ function settings_content(&$a) {
 		($a->user['account-type'] != ACCOUNT_TYPE_COMMUNITY))
 		$a->user['account-type'] = ACCOUNT_TYPE_COMMUNITY;
 
-	$pageset_tpl = get_markup_template('pagetypes.tpl');
+	$pageset_tpl = get_markup_template('settings_pagetypes.tpl');
 
 	$pagetype = replace_macros($pageset_tpl, array(
 		'$account_types'	=> t("Account Types"),
diff --git a/view/global.css b/view/global.css
index 40919542de..1bc2f11d68 100644
--- a/view/global.css
+++ b/view/global.css
@@ -455,3 +455,8 @@ td.federation-data {
   display: none;
   margin: 10px 0;
 }
+
+/* settings page */
+#settings-form .pageflags {
+    margin: 0 0 20px 30px;
+}
diff --git a/view/templates/pagetypes.tpl b/view/templates/pagetypes.tpl
deleted file mode 100644
index b970f7745f..0000000000
--- a/view/templates/pagetypes.tpl
+++ /dev/null
@@ -1,26 +0,0 @@
-<h4>{{$account_types}}</h4>
-{{include file="field_radio.tpl" field=$account_person}}
-{{include file="field_radio.tpl" field=$account_organisation}}
-{{include file="field_radio.tpl" field=$account_news}}
-{{include file="field_radio.tpl" field=$account_community}}
-
-{{if $account_type == $type_person}}
-	<h5>{{$user}}</h5>
-	{{include file="field_radio.tpl" field=$page_normal}}
-	{{include file="field_radio.tpl" field=$page_soapbox}}
-	{{include file="field_radio.tpl" field=$page_freelove}}
-{{/if}}
-
-{{if $account_type == $type_organisation}}
-	<input type='hidden' name='page-flags' value='1'>
-{{/if}}
-
-{{if $account_type == $type_news}}
-	<input type='hidden' name='page-flags' value='1'>
-{{/if}}
-
-{{if $account_type == $type_community}}
-	<h5>{{$community}}</h5>
-	{{include file="field_radio.tpl" field=$page_community}}
-	{{include file="field_radio.tpl" field=$page_prvgroup}}
-{{/if}}
diff --git a/view/templates/settings_pagetypes.tpl b/view/templates/settings_pagetypes.tpl
new file mode 100644
index 0000000000..1c2f96e81f
--- /dev/null
+++ b/view/templates/settings_pagetypes.tpl
@@ -0,0 +1,71 @@
+
+<h4>{{$account_types}}</h4>
+{{include file="field_radio.tpl" field=$account_person}}
+<div id="account-type-sub-0" class="pageflags">
+	<h5>{{$user}}</h5>
+	{{include file="field_radio.tpl" field=$page_normal}}
+	{{include file="field_radio.tpl" field=$page_soapbox}}
+	{{include file="field_radio.tpl" field=$page_freelove}}
+</div>
+
+{{include file="field_radio.tpl" field=$account_organisation}}
+{{include file="field_radio.tpl" field=$account_news}}
+
+{{include file="field_radio.tpl" field=$account_community}}
+<div id="account-type-sub-3" class="pageflags">
+	<h5>{{$community}}</h5>
+	{{include file="field_radio.tpl" field=$page_community}}
+	{{include file="field_radio.tpl" field=$page_prvgroup}}
+</div>
+
+<script language="javascript" type="text/javascript">
+	// This js part changes the state of page-flags radio buttons according
+	// to the selected account type. For a translation of the different
+	// account-types and page-flags have a look in the define section in boot.php
+	var accountType = {{$account_type}};
+
+	$(document).ready(function(){
+		// Hide all DIV for page-flags expet the one which belongs to the present
+		// account-type
+		showPageFlags(accountType);
+
+		// Save the ID of the active page-flage
+		var activeFlag = $('[id^=id_page-flags_]:checked');
+
+		$("[id^=id_account-type_]").change(function(){
+			// Since the ID of the radio buttons containing the type of
+			// the account-type we catch the last character of the ID to
+			// know for what account-type the radio button stands for.
+			var type = this.id.substr(this.id.length - 1);
+
+			// Hide all DIV with page-flags and show only the one which belongs
+			// to the selected radio button
+			showPageFlags(type);
+
+			// Uncheck all page-flags radio buttons
+			$('input:radio[name="page-flags"]').prop("checked", false);
+
+			// If the selected account type is the active one mark the page-flag
+			// radio button as checked which is already by database state
+			if (accountType == type) {
+				$(activeFlag).prop("checked", true);
+			} else if (type == 1 || type == 2) {
+				// For account-type 1 or 2 the page-flags are always set to 1
+				$('#id_page-flags_1').prop("checked", true);
+			} else {
+				// Mark the first available page-flags radio button of the selected
+				// account-type as checked
+				$('#account-type-sub-' + type + ' input:radio[name="page-flags"]').first().prop("checked", true);
+			}
+		});
+	});
+
+	// Show/Hide the page-flags according to the selected account-type
+	function showPageFlags(type) {
+		$(".pageflags").hide();
+
+		if (type == 0 || type == 3) {
+			$("#account-type-sub-" + type).show();
+		}
+	}
+</script>