diff --git a/include/dba.php b/include/dba.php index dd4272c994..391a6fcf72 100644 --- a/include/dba.php +++ b/include/dba.php @@ -1303,7 +1303,7 @@ function dbesc($str) { * dba::delete, dba::update, dba::p, dba::e * * @param $args Query parameters (1 to N parameters of different types) - * @return array Query array + * @return array|bool Query array */ function q($sql) { $args = func_get_args(); diff --git a/mod/contacts.php b/mod/contacts.php index c58dc0fc4f..b347617a1c 100644 --- a/mod/contacts.php +++ b/mod/contacts.php @@ -1,4 +1,5 @@ argc == 2) && intval($a->argv[1])) || (($a->argc == 3) && intval($a->argv[1]) && ($a->argv[2] == "posts"))) { - $contact_id = intval($a->argv[1]); - $r = q("SELECT * FROM `contact` WHERE `uid` = %d and `id` = %d LIMIT 1", - intval(local_user()), - intval($contact_id) - ); - if (! DBM::is_result($r)) { - $contact_id = 0; - } - } - - require_once 'include/contact_widgets.php'; - $nets = defaults($_GET, 'nets', ''); if ($nets == "all") { $nets = ""; } - if (! x($a->page,'aside')) { + if (!x($a->page, 'aside')) { $a->page['aside'] = ''; } - if ($contact_id) { - $a->data['contact'] = $r[0]; + $contact = []; + if ((($a->argc == 2) && intval($a->argv[1])) || (($a->argc == 3) && intval($a->argv[1]) && ($a->argv[2] == "posts"))) { + $contact_id = intval($a->argv[1]); + $contact = dba::select('contact', [], ['id' => $contact_id, 'uid' => local_user()], ['limit' => 1]); + } + + if (DBM::is_result($contact)) { + $a->data['contact'] = $contact; if (($a->data['contact']['network'] != "") && ($a->data['contact']['network'] != NETWORK_DFRN)) { - $networkname = format_network_name($a->data['contact']['network'],$a->data['contact']['url']); + $networkname = format_network_name($a->data['contact']['network'], $a->data['contact']['url']); } else { $networkname = ''; } /// @TODO Add nice spaces - $vcard_widget = replace_macros(get_markup_template("vcard-widget.tpl"),array( + $vcard_widget = replace_macros(get_markup_template("vcard-widget.tpl"), array( '$name' => htmlentities($a->data['contact']['name']), '$photo' => $a->data['contact']['photo'], - '$url' => ($a->data['contact']['network'] == NETWORK_DFRN) ? "redir/".$a->data['contact']['id'] : $a->data['contact']['url'], + '$url' => ($a->data['contact']['network'] == NETWORK_DFRN) ? "redir/" . $a->data['contact']['id'] : $a->data['contact']['url'], '$addr' => (($a->data['contact']['addr'] != "") ? ($a->data['contact']['addr']) : ""), '$network_name' => $networkname, '$network' => t('Network:'), @@ -79,9 +73,9 @@ function contacts_init(App $a) { $findpeople_widget = findpeople_widget(); } - $groups_widget = Group::sidebarWidget('contacts','group','full',0,$contact_id); + $groups_widget = Group::sidebarWidget('contacts', 'group', 'full', 0, $contact_id); - $a->page['aside'] .= replace_macros(get_markup_template("contacts-widget-sidebar.tpl"),array( + $a->page['aside'] .= replace_macros(get_markup_template("contacts-widget-sidebar.tpl"), array( '$vcard_widget' => $vcard_widget, '$findpeople_widget' => $findpeople_widget, '$follow_widget' => $follow_widget, @@ -91,80 +85,84 @@ function contacts_init(App $a) { $base = System::baseUrl(); $tpl = get_markup_template("contacts-head.tpl"); - $a->page['htmlhead'] .= replace_macros($tpl,array( + $a->page['htmlhead'] .= replace_macros($tpl, array( '$baseurl' => System::baseUrl(true), '$base' => $base )); $tpl = get_markup_template("contacts-end.tpl"); - $a->page['end'] .= replace_macros($tpl,array( + $a->page['end'] .= replace_macros($tpl, array( '$baseurl' => System::baseUrl(true), '$base' => $base )); - - } -function contacts_batch_actions(App $a) { +function contacts_batch_actions(App $a) +{ $contacts_id = $_POST['contact_batch']; - if (!is_array($contacts_id)) return; + if (!is_array($contacts_id)) { + return; + } $orig_records = q("SELECT * FROM `contact` WHERE `id` IN (%s) AND `uid` = %d AND `self` = 0", implode(",", $contacts_id), intval(local_user()) ); - $count_actions=0; - foreach($orig_records as $orig_record) { + $count_actions = 0; + foreach ($orig_records as $orig_record) { $contact_id = $orig_record['id']; if (x($_POST, 'contacts_batch_update')) { _contact_update($contact_id); $count_actions++; } if (x($_POST, 'contacts_batch_block')) { - $r = _contact_block($contact_id, $orig_record); - if ($r) $count_actions++; + $r = _contact_block($contact_id, $orig_record); + if ($r) { + $count_actions++; + } } if (x($_POST, 'contacts_batch_ignore')) { $r = _contact_ignore($contact_id, $orig_record); - if ($r) $count_actions++; + if ($r) { + $count_actions++; + } } if (x($_POST, 'contacts_batch_archive')) { $r = _contact_archive($contact_id, $orig_record); - if ($r) $count_actions++; + if ($r) { + $count_actions++; + } } if (x($_POST, 'contacts_batch_drop')) { _contact_drop($orig_record); $count_actions++; } } - if ($count_actions>0) { - info ( sprintf( tt("%d contact edited.", "%d contacts edited.", $count_actions), $count_actions) ); + if ($count_actions > 0) { + info(tt("%d contact edited.", "%d contacts edited.", $count_actions)); } - if (x($_SESSION,'return_url')) { + if (x($_SESSION, 'return_url')) { goaway('' . $_SESSION['return_url']); - } - else { + } else { goaway('contacts'); } - } - -function contacts_post(App $a) { - - if (! local_user()) { +function contacts_post(App $a) +{ + if (!local_user()) { return; } - if ($a->argv[1]==="batch") { + if ($a->argv[1] === "batch") { contacts_batch_actions($a); return; } $contact_id = intval($a->argv[1]); - if (! $contact_id) { + if (!$contact_id) { return; } @@ -172,9 +170,8 @@ function contacts_post(App $a) { intval($contact_id), intval(local_user()) ); - - if (! count($orig_record)) { - notice( t('Could not access contact record.') . EOL); + if (!DBM::is_result($orig_record)) { + notice(t('Could not access contact record.') . EOL); goaway('contacts'); return; // NOTREACHED } @@ -187,8 +184,8 @@ function contacts_post(App $a) { intval($profile_id), intval(local_user()) ); - if (! DBM::is_result($r)) { - notice( t('Could not locate selected profile.') . EOL); + if (!DBM::is_result($r)) { + notice(t('Could not locate selected profile.') . EOL); return; } } @@ -202,8 +199,9 @@ function contacts_post(App $a) { $ffi_keyword_blacklist = escape_tags(trim($_POST['ffi_keyword_blacklist'])); $priority = intval($_POST['poll']); - if($priority > 5 || $priority < 0) + if ($priority > 5 || $priority < 0) { $priority = 0; + } $info = escape_tags(trim($_POST['info'])); @@ -220,91 +218,95 @@ function contacts_post(App $a) { intval($contact_id), intval(local_user()) ); - if($r) - info( t('Contact updated.') . EOL); - else - notice( t('Failed to update contact record.') . EOL); + if (DBM::is_result($r)) { + info(t('Contact updated.') . EOL); + } else { + notice(t('Failed to update contact record.') . EOL); + } - $r = q("select * from contact where id = %d and uid = %d limit 1", - intval($contact_id), - intval(local_user()) - ); - if($r && DBM::is_result($r)) - $a->data['contact'] = $r[0]; + $contact = dba::select('contact', [], ['id' => $contact_id, 'uid' => local_user()], ['limit' => 1]); + if (DBM::is_result($contact)) { + $a->data['contact'] = $contact; + } return; - } +/* contact actions */ -/*contact actions*/ -function _contact_update($contact_id) { - $r = q("SELECT `uid`, `url`, `network` FROM `contact` WHERE `id` = %d", intval($contact_id)); - if (!$r) +function _contact_update($contact_id) +{ + $contact = dba::select('contact', ['uid', 'url', 'network'], ['id' => $contact_id, 'uid' => local_user()], ['limit' => 1]); + if (!DBM::is_result($contact)) { return; + } - $uid = $r[0]["uid"]; - - if ($uid != local_user()) - return; + $uid = $contact["uid"]; if ($r[0]["network"] == NETWORK_OSTATUS) { - $result = new_contact($uid, $r[0]["url"], false, $r[0]["network"]); + $result = new_contact($uid, $contact["url"], false, $contact["network"]); - if ($result['success']) - $r = q("UPDATE `contact` SET `subhub` = 1 WHERE `id` = %d", - intval($contact_id)); - } else + if ($result['success']) { + q("UPDATE `contact` SET `subhub` = 1 WHERE `id` = %d", intval($contact_id)); + } + } else { // pull feed and consume it, which should subscribe to the hub. Worker::add(PRIORITY_HIGH, "OnePoll", $contact_id, "force"); + } } -function _contact_update_profile($contact_id) { - $r = q("SELECT `uid`, `url`, `network` FROM `contact` WHERE `id` = %d", intval($contact_id)); - if (!$r) +function _contact_update_profile($contact_id) +{ + $contact = dba::select('contact', ['uid', 'url', 'network'], ['id' => $contact_id, 'uid' => local_user()], ['limit' => 1]); + if (!DBM::is_result($contact)) { return; + } - $uid = $r[0]["uid"]; + $uid = $contact["uid"]; - if ($uid != local_user()) - return; - - $data = Probe::uri($r[0]["url"], "", 0, false); + $data = Probe::uri($contact["url"], "", 0, false); // "Feed" or "Unknown" is mostly a sign of communication problems - if ((in_array($data["network"], array(NETWORK_FEED, NETWORK_PHANTOM))) && ($data["network"] != $r[0]["network"])) + if ((in_array($data["network"], array(NETWORK_FEED, NETWORK_PHANTOM))) && ($data["network"] != $contact["network"])) { return; + } $updatefields = array("name", "nick", "url", "addr", "batch", "notify", "poll", "request", "confirm", - "poco", "network", "alias"); + "poco", "network", "alias"); $update = array(); if ($data["network"] == NETWORK_OSTATUS) { $result = new_contact($uid, $data["url"], false); - if ($result['success']) + if ($result['success']) { $update["subhub"] = true; + } } - foreach($updatefields AS $field) - if (isset($data[$field]) && ($data[$field] != "")) + foreach ($updatefields AS $field) { + if (isset($data[$field]) && ($data[$field] != "")) { $update[$field] = $data[$field]; + } + } $update["nurl"] = normalise_link($data["url"]); $query = ""; - if (isset($data["priority"]) && ($data["priority"] != 0)) - $query = "`priority` = ".intval($data["priority"]); - - foreach($update AS $key => $value) { - if ($query != "") - $query .= ", "; - - $query .= "`".$key."` = '".dbesc($value)."'"; + if (isset($data["priority"]) && ($data["priority"] != 0)) { + $query = "`priority` = " . intval($data["priority"]); } - if ($query == "") + foreach ($update AS $key => $value) { + if ($query != "") { + $query .= ", "; + } + + $query .= "`" . $key . "` = '" . dbesc($value) . "'"; + } + + if ($query == "") { return; + } $r = q("UPDATE `contact` SET $query WHERE `id` = %d AND `uid` = %d", intval($contact_id), @@ -318,26 +320,30 @@ function _contact_update_profile($contact_id) { GContact::updateFromProbe($data["url"]); } -function _contact_block($contact_id, $orig_record) { +function _contact_block($contact_id, $orig_record) +{ $blocked = (($orig_record['blocked']) ? 0 : 1); $r = q("UPDATE `contact` SET `blocked` = %d WHERE `id` = %d AND `uid` = %d", intval($blocked), intval($contact_id), intval(local_user()) ); - return $r; - + return DBM::is_result($r); } -function _contact_ignore($contact_id, $orig_record) { + +function _contact_ignore($contact_id, $orig_record) +{ $readonly = (($orig_record['readonly']) ? 0 : 1); $r = q("UPDATE `contact` SET `readonly` = %d WHERE `id` = %d AND `uid` = %d", intval($readonly), intval($contact_id), intval(local_user()) ); - return $r; + return DBM::is_result($r); } -function _contact_archive($contact_id, $orig_record) { + +function _contact_archive($contact_id, $orig_record) +{ $archived = (($orig_record['archive']) ? 0 : 1); $r = q("UPDATE `contact` SET `archive` = %d WHERE `id` = %d AND `uid` = %d", intval($archived), @@ -347,7 +353,7 @@ function _contact_archive($contact_id, $orig_record) { if ($archived) { q("UPDATE `item` SET `private` = 2 WHERE `contact-id` = %d AND `uid` = %d", intval($contact_id), intval(local_user())); } - return $r; + return DBM::is_result($r); } function _contact_drop($orig_record) @@ -366,94 +372,86 @@ function _contact_drop($orig_record) Contact::remove($orig_record['id']); } - -function contacts_content(App $a) { - +function contacts_content(App $a) +{ $sort_type = 0; $o = ''; nav_set_selected('contacts'); - - if (! local_user()) { - notice( t('Permission denied.') . EOL); + if (!local_user()) { + notice(t('Permission denied.') . EOL); return; } - if($a->argc == 3) { - + if ($a->argc == 3) { $contact_id = intval($a->argv[1]); - if(! $contact_id) + if (!$contact_id) { return; + } $cmd = $a->argv[2]; - $orig_record = q("SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d AND `self` = 0 LIMIT 1", - intval($contact_id), - intval(local_user()) - ); - - if(! count($orig_record)) { - notice( t('Could not access contact record.') . EOL); + $orig_record = dba::select('contact', [], ['id' => $contact_id, 'uid' => local_user(), 'self' => false], ['limit' => 1]); + if (!DBM::is_result($orig_record)) { + notice(t('Could not access contact record.') . EOL); goaway('contacts'); return; // NOTREACHED } - if($cmd === 'update') { + if ($cmd === 'update') { _contact_update($contact_id); goaway('contacts/' . $contact_id); // NOTREACHED } - if($cmd === 'updateprofile') { + if ($cmd === 'updateprofile') { _contact_update_profile($contact_id); goaway('crepair/' . $contact_id); // NOTREACHED } - if($cmd === 'block') { - $r = _contact_block($contact_id, $orig_record[0]); + if ($cmd === 'block') { + $r = _contact_block($contact_id, $orig_record); if ($r) { - $blocked = (($orig_record[0]['blocked']) ? 0 : 1); - info((($blocked) ? t('Contact has been blocked') : t('Contact has been unblocked')).EOL); + $blocked = (($orig_record['blocked']) ? 0 : 1); + info((($blocked) ? t('Contact has been blocked') : t('Contact has been unblocked')) . EOL); } goaway('contacts/' . $contact_id); return; // NOTREACHED } - if($cmd === 'ignore') { - $r = _contact_ignore($contact_id, $orig_record[0]); + if ($cmd === 'ignore') { + $r = _contact_ignore($contact_id, $orig_record); if ($r) { - $readonly = (($orig_record[0]['readonly']) ? 0 : 1); - info((($readonly) ? t('Contact has been ignored') : t('Contact has been unignored')).EOL); + $readonly = (($orig_record['readonly']) ? 0 : 1); + info((($readonly) ? t('Contact has been ignored') : t('Contact has been unignored')) . EOL); } goaway('contacts/' . $contact_id); return; // NOTREACHED } - - if($cmd === 'archive') { - $r = _contact_archive($contact_id, $orig_record[0]); + if ($cmd === 'archive') { + $r = _contact_archive($contact_id, $orig_record); if ($r) { - $archived = (($orig_record[0]['archive']) ? 0 : 1); - info((($archived) ? t('Contact has been archived') : t('Contact has been unarchived')).EOL); + $archived = (($orig_record['archive']) ? 0 : 1); + info((($archived) ? t('Contact has been archived') : t('Contact has been unarchived')) . EOL); } goaway('contacts/' . $contact_id); return; // NOTREACHED } - if($cmd === 'drop') { - + if ($cmd === 'drop') { // Check if we should do HTML-based delete confirmation - if($_REQUEST['confirm']) { + if (x($_REQUEST, 'confirm')) { //