Don't allow negative values in meta doc usage numbers

federation/hostmeta/parsers.py

@@ -36,7 +36,10 @@ def int_or_none(value):
     if value is None or value == '':
         return None
     try:
-        return int(value)
+        result = int(value)
+        if result < 0:
+            return None
+        return result
     except ValueError:
         return None
 

federation/tests/hostmeta/test_parsers.py

@@ -1,10 +1,15 @@
 import json
-from unittest.mock import patch
 
-from federation.hostmeta.parsers import parse_nodeinfo_document, parse_nodeinfo2_document, parse_statisticsjson_document
+from federation.hostmeta.parsers import (
+    parse_nodeinfo_document, parse_nodeinfo2_document, parse_statisticsjson_document, int_or_none)
 from federation.tests.fixtures.hostmeta import NODEINFO2_10_DOC, NODEINFO_10_DOC, NODEINFO_20_DOC, STATISTICS_JSON_DOC
 
 
+class TestIntOrNone:
+    def test_returns_negative_values_as_none(self):
+        assert int_or_none(-1) is None
+
+
 class TestParseNodeInfoDocument:
     def test_parse_nodeinfo_10_document(self):
         result = parse_nodeinfo_document(json.loads(NODEINFO_10_DOC), 'iliketoast.net')