Fix for issue #137 - PC/PG changes now take effect immediately as expected. Updated docs.

pull/138/head
EmbeddedMan 2020-05-27 09:19:05 -05:00
rodzic aa3fa7f382
commit 04c5ad54c1
6 zmienionych plików z 23 dodań i 58 usunięć

Wyświetl plik

@ -68,7 +68,7 @@
<targetPluginBoard></targetPluginBoard>
<platformTool></platformTool>
<languageToolchain>C18</languageToolchain>
<languageToolchainVersion>3.46</languageToolchainVersion>
<languageToolchainVersion>3.47</languageToolchainVersion>
<platform>3</platform>
</toolsSet>
<packs>
@ -225,7 +225,7 @@
<targetPluginBoard></targetPluginBoard>
<platformTool></platformTool>
<languageToolchain>C18</languageToolchain>
<languageToolchainVersion>3.46</languageToolchainVersion>
<languageToolchainVersion>3.47</languageToolchainVersion>
<platform>3</platform>
</toolsSet>
<packs>

Wyświetl plik

@ -39,59 +39,5 @@
</environment>
</runprofile>
</conf>
<conf name="EBBv13_XC8_no_bootloader" type="2">
<platformToolSN></platformToolSN>
<languageToolchainDir>C:\Program Files (x86)\Microchip\xc8\v2.00\bin</languageToolchainDir>
<mdbdebugger version="1">
<placeholder1>place holder 1</placeholder1>
<placeholder2>place holder 2</placeholder2>
</mdbdebugger>
<runprofile version="6">
<args></args>
<rundir></rundir>
<buildfirst>true</buildfirst>
<console-type>0</console-type>
<terminal-type>0</terminal-type>
<remove-instrumentation>0</remove-instrumentation>
<environment>
</environment>
</runprofile>
</conf>
<conf name="EBBv13_XC8_with_bootloader" type="2">
<platformToolSN></platformToolSN>
<languageToolchainDir>C:\Program Files (x86)\Microchip\xc8\v2.00\bin</languageToolchainDir>
<mdbdebugger version="1">
<placeholder1>place holder 1</placeholder1>
<placeholder2>place holder 2</placeholder2>
</mdbdebugger>
<runprofile version="6">
<args></args>
<rundir></rundir>
<buildfirst>true</buildfirst>
<console-type>0</console-type>
<terminal-type>0</terminal-type>
<remove-instrumentation>0</remove-instrumentation>
<environment>
</environment>
</runprofile>
</conf>
<conf name="EBBv13_45J50_with_bootloader" type="2">
<platformToolSN></platformToolSN>
<languageToolchainDir>C:\MCC18\bin</languageToolchainDir>
<mdbdebugger version="1">
<placeholder1>place holder 1</placeholder1>
<placeholder2>place holder 2</placeholder2>
</mdbdebugger>
<runprofile version="6">
<args></args>
<rundir></rundir>
<buildfirst>true</buildfirst>
<console-type>0</console-type>
<terminal-type>0</terminal-type>
<remove-instrumentation>0</remove-instrumentation>
<environment>
</environment>
</runprofile>
</conf>
</confs>
</configurationDescriptor>

Wyświetl plik

@ -158,7 +158,7 @@ const rom char st_LFCR[] = {"\r\n"};
#elif defined(BOARD_EBB_V12)
const rom char st_version[] = {"EBBv12 EB Firmware Version 2.2.1\r\n"};
#elif defined(BOARD_EBB_V13_AND_ABOVE)
const rom char st_version[] = {"EBBv13_and_above EB Firmware Version 2.6.5\r\n"};
const rom char st_version[] = {"EBBv13_and_above EB Firmware Version 2.6.6\r\n"};
#elif defined(BOARD_UBW)
const rom char st_version[] = {"UBW EB Firmware Version 2.2.1\r\n"};
#endif
@ -501,7 +501,7 @@ void low_ISR(void)
gPulseCounters[i]++;
// And check to see if we've reached the end of the rate
if (gPulseCounters[i] == gPulseRate[i])
if (gPulseCounters[i] >= gPulseRate[i])
{
// If so, start over from zero
gPulseCounters[i] = 0;

Wyświetl plik

@ -238,6 +238,8 @@
// input parameters)
// 2.6.5 11/29/19 - Changed SR command behavior so it only enables servo power
// after SP command, not also after stepper movement
// 2.6.6 05/26/20 - Fixed a bug with the PC/PG command which caused some changes
// not to take effect for up to 64K more milliseconds.
#include <p18cxxx.h>
#include <usart.h>

Wyświetl plik

@ -339,6 +339,14 @@
</ul>
</p>
<h4>2.6.6 &mdash; 05/26/20</h4>
<p>
<ul>
<li>In response to <a href="https://github.com/evil-mad/EggBot/issues/137">issue #137</a> Fixed a bug with the
PC/PG command which caused some PC command changes not to take effect for up to 64K more milliseconds.</li>
</ul>
</p>
<p/>
<hr/>
<p/>

Wyświetl plik

@ -1064,6 +1064,15 @@ td {text-align: center}
This command is only available for pins RB0, RB1, RB2 and RB3. If you wish to leave a pin alone (i.e. not create pulses on it) just set its Length and Period values to zero.
</p>
</li>
<li>
<span style="font-weight: bold;">Version History:</span>
<p>
Version 2.6.6 and later : The bug preventing some <code>PC</code> changes from acting immediately is fixed and <code>PC/PG</code> work properly.
</p>
<p>
Version 2.6.5 and before : There is a bug in the <code>PC/PG</code> functions which prevent some <code>PC</code> updates from taking effect immediately but instead requiring 64K milliseconds to elapse before the change takes effect.
</p>
</li>
</ul>
<hr class="short"/>