From eb85c4ec152c1f1810001ed5cbc4906385999748 Mon Sep 17 00:00:00 2001 From: Ivan Grokhotkov Date: Mon, 2 Jul 2018 21:45:27 +0800 Subject: [PATCH] tiny-test-fw: handle case when ESPPORT is not set Fix bug introduced in 8a88dd35, where .decode was called on result of os.getenv, which was None if ESPPORT was not set. --- tools/tiny-test-fw/IDF/IDFDUT.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/tiny-test-fw/IDF/IDFDUT.py b/tools/tiny-test-fw/IDF/IDFDUT.py index d0baa7c1b4..b5434d5fba 100644 --- a/tools/tiny-test-fw/IDF/IDFDUT.py +++ b/tools/tiny-test-fw/IDF/IDFDUT.py @@ -131,7 +131,11 @@ class IDFDUT(DUT.SerialDUT): @classmethod def list_available_ports(cls): ports = [x.device for x in list_ports.comports()] - port_hint = os.getenv('ESPPORT').decode('utf8') + espport = os.getenv('ESPPORT') + if not espport: + return ports + + port_hint = espport.decode('utf8') # If $ESPPORT is a valid port, make it appear first in the list if port_hint in ports: