Merge branch 'fix/esp_tls_add_warning_if_ca_chain_has_invalid_cert' into 'master'

esp_tls: Add warning if the CA chain provided contains invalid cert

See merge request espressif/esp-idf!11851
pull/6416/head
Mahavir Jain 2021-01-11 14:00:21 +08:00
commit 957706f085
1 zmienionych plików z 5 dodań i 0 usunięć

Wyświetl plik

@ -275,6 +275,11 @@ static esp_err_t set_ca_cert(esp_tls_t *tls, const unsigned char *cacert, size_t
ESP_INT_EVENT_TRACKER_CAPTURE(tls->error_handle, ESP_TLS_ERR_TYPE_MBEDTLS, -ret);
return ESP_ERR_MBEDTLS_X509_CRT_PARSE_FAILED;
}
if (ret > 0) {
/* This will happen if the CA chain contains one or more invalid certs, going ahead as the hadshake
* may still succeed if the other certificates in the CA chain are enough for the authentication */
ESP_LOGW(TAG, "mbedtls_x509_crt_parse was partly successful. No. of failed certificates: %d", ret);
}
mbedtls_ssl_conf_authmode(&tls->conf, MBEDTLS_SSL_VERIFY_REQUIRED);
mbedtls_ssl_conf_ca_chain(&tls->conf, tls->cacert_ptr, NULL);
return ESP_OK;