From 916d2f6f4c64c359c569deac4e451dee0a24c9aa Mon Sep 17 00:00:00 2001 From: David Cermak Date: Mon, 2 Nov 2020 20:41:46 +0100 Subject: [PATCH] esp_netif: Added test for failing to set hostname --- components/esp_netif/test/test_esp_netif.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/components/esp_netif/test/test_esp_netif.c b/components/esp_netif/test/test_esp_netif.c index 69f158cd4f..5140be7bbe 100644 --- a/components/esp_netif/test/test_esp_netif.c +++ b/components/esp_netif/test/test_esp_netif.c @@ -275,5 +275,13 @@ TEST_CASE("esp_netif: get/set hostname", "[esp_netif]") TEST_ASSERT_EQUAL(ESP_OK, esp_netif_get_hostname(esp_netif, &hostname)); TEST_ASSERT_EQUAL_STRING(hostname, "new_name"); + // test that setting the long name is refused and the previously set value retained + #define ESP_NETIF_HOSTNAME_MAX_SIZE 32 + char long_name[ESP_NETIF_HOSTNAME_MAX_SIZE + 2] = { 0 }; + memset(long_name, 'A', ESP_NETIF_HOSTNAME_MAX_SIZE+1); // construct the long name + TEST_ASSERT_NOT_EQUAL(ESP_OK, esp_netif_set_hostname(esp_netif, long_name)); + TEST_ASSERT_EQUAL(ESP_OK, esp_netif_get_hostname(esp_netif, &hostname)); + TEST_ASSERT_EQUAL_STRING(hostname, "new_name"); + esp_netif_destroy(esp_netif); }