diff --git a/examples/protocols/pppos_client/components/modem/src/bg96.c b/examples/protocols/pppos_client/components/modem/src/bg96.c index eecbdedf73..da5c202d6a 100644 --- a/examples/protocols/pppos_client/components/modem/src/bg96.c +++ b/examples/protocols/pppos_client/components/modem/src/bg96.c @@ -160,7 +160,7 @@ static esp_err_t bg96_handle_cimi(modem_dce_t *dce, const char *line) * @brief Handle response from AT+COPS? */ static esp_err_t bg96_handle_cops(modem_dce_t *dce, const char *line) -{ +{ esp_err_t err = ESP_FAIL; if (strstr(line, MODEM_RESULT_CODE_SUCCESS)) { err = esp_modem_process_command_done(dce, MODEM_STATE_SUCCESS); @@ -172,7 +172,7 @@ static esp_err_t bg96_handle_cops(modem_dce_t *dce, const char *line) size_t len = strlen(line); char *line_copy = malloc(len + 1); strcpy(line_copy, line); - /* +COPS: [, [, ][, ]] */ + /* +COPS: [, [, [, ]]] */ char *str_ptr = NULL; char *p[5]; uint8_t i = 0; @@ -190,9 +190,7 @@ static esp_err_t bg96_handle_cops(modem_dce_t *dce, const char *line) } } if (i >= 4) { - char act_str[3] = {0}; - int len = snprintf(act_str, 3, "%s", p[3]); - dce->act = (uint8_t)atoi(act_str); + dce->act = (uint8_t)strtol(p[3], NULL, 0); } free(line_copy); } @@ -469,6 +467,8 @@ modem_dce_t *bg96_init(modem_dte_t *dte) DCE_CHECK(bg96_get_imei_number(bg96_dce) == ESP_OK, "get imei failed", err_io); /* Get IMSI number */ DCE_CHECK(bg96_get_imsi_number(bg96_dce) == ESP_OK, "get imsi failed", err_io); + /* Get operator name */ + DCE_CHECK(bg96_get_operator_name(&(bg96_dce->parent)) == ESP_OK, "get operator name failed", err_io); return &(bg96_dce->parent); err_io: free(bg96_dce); diff --git a/examples/protocols/pppos_client/components/modem/src/sim800.c b/examples/protocols/pppos_client/components/modem/src/sim800.c index d2ced136a9..177a288e88 100644 --- a/examples/protocols/pppos_client/components/modem/src/sim800.c +++ b/examples/protocols/pppos_client/components/modem/src/sim800.c @@ -194,9 +194,9 @@ static esp_err_t sim800_handle_cops(modem_dce_t *dce, const char *line) size_t len = strlen(line); char *line_copy = malloc(len + 1); strcpy(line_copy, line); - /* +COPS: [, [, ]] */ + /* +COPS: [, [, [, ]]] */ char *str_ptr = NULL; - char *p[3]; + char *p[5]; uint8_t i = 0; /* strtok will broke string by replacing delimiter with '\0' */ p[i] = strtok_r(line_copy, ",", &str_ptr); @@ -211,6 +211,9 @@ static esp_err_t sim800_handle_cops(modem_dce_t *dce, const char *line) err = ESP_OK; } } + if (i >= 4) { + dce->act = (uint8_t)strtol(p[3], NULL, 0); + } free(line_copy); } return err; @@ -415,14 +418,15 @@ err: /** * @brief Get Operator's name * - * @param sim800_dce sim800 object + * @param dce Modem DCE object * @return esp_err_t * - ESP_OK on success * - ESP_FAIL on error */ -static esp_err_t sim800_get_operator_name(sim800_modem_dce_t *sim800_dce) +static esp_err_t sim800_get_operator_name(modem_dce_t *dce) { - modem_dte_t *dte = sim800_dce->parent.dte; + modem_dte_t *dte = dce->dte; + sim800_modem_dce_t *sim800_dce = __containerof(dce, sim800_modem_dce_t, parent); sim800_dce->parent.handle_line = sim800_handle_cops; DCE_CHECK(dte->send_cmd(dte, "AT+COPS?\r", MODEM_COMMAND_TIMEOUT_OPERATOR) == ESP_OK, "send command failed", err); DCE_CHECK(sim800_dce->parent.state == MODEM_STATE_SUCCESS, "get network operator failed", err); @@ -469,6 +473,7 @@ modem_dce_t *sim800_init(modem_dte_t *dte) sim800_dce->parent.hang_up = esp_modem_dce_hang_up; sim800_dce->parent.get_signal_quality = sim800_get_signal_quality; sim800_dce->parent.get_battery_status = sim800_get_battery_status; + sim800_dce->parent.get_operator_name = sim800_get_operator_name; sim800_dce->parent.set_working_mode = sim800_set_working_mode; sim800_dce->parent.power_down = sim800_power_down; sim800_dce->parent.deinit = sim800_deinit; @@ -483,7 +488,7 @@ modem_dce_t *sim800_init(modem_dte_t *dte) /* Get IMSI number */ DCE_CHECK(sim800_get_imsi_number(sim800_dce) == ESP_OK, "get imsi failed", err_io); /* Get operator name */ - DCE_CHECK(sim800_get_operator_name(sim800_dce) == ESP_OK, "get operator name failed", err_io); + DCE_CHECK(sim800_get_operator_name(&(sim800_dce->parent)) == ESP_OK, "get operator name failed", err_io); return &(sim800_dce->parent); err_io: free(sim800_dce); diff --git a/examples/protocols/pppos_client/main/Kconfig.projbuild b/examples/protocols/pppos_client/main/Kconfig.projbuild index ca02b41d12..f0237c6d98 100644 --- a/examples/protocols/pppos_client/main/Kconfig.projbuild +++ b/examples/protocols/pppos_client/main/Kconfig.projbuild @@ -86,7 +86,7 @@ menu "Example Configuration" config EXAMPLE_MODEM_UART_EVENT_TASK_STACK_SIZE int "UART Event Task Stack Size" range 2000 6000 - default 2048 + default 3072 help Stack size of UART event task.