Merge branch 'bugfix/http_client_test_memcorupt_v4.0' into 'release/v4.0'

ci/test: Fix esp_http_client test not to use pointer after free (v4.0)

See merge request espressif/esp-idf!13703
release/v4.0
Mahavir Jain 2021-07-02 12:17:59 +00:00
commit 7b994feb13
1 zmienionych plików z 4 dodań i 1 usunięć

Wyświetl plik

@ -124,7 +124,10 @@ TEST_CASE("Username and password will not reset if new absolute URL doesnot spec
TEST_ASSERT_EQUAL_STRING(USERNAME, value);
esp_http_client_set_url(client, "http://" HOST "/get");
esp_http_client_set_username(client, value);
esp_http_client_set_password(client, value);
// esp_http_client_set_username sets new username and thus invalidates the original one
// which we still reference in the local variable `value` (better forget it)
value = NULL;
esp_http_client_set_password(client, (char *)USERNAME); // Need to cast the string literal (argument is not a const char*)
//checks if username is set or not
r = esp_http_client_get_username(client, &value);
TEST_ASSERT_EQUAL(ESP_OK, r);