From a0f3f1e0cb3b91777d5758888c441db74041129d Mon Sep 17 00:00:00 2001 From: Renz Bagaporo Date: Wed, 13 May 2020 15:38:20 +0800 Subject: [PATCH 1/2] cmake: make __idf_build_target global --- tools/cmake/build.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/cmake/build.cmake b/tools/cmake/build.cmake index d7b91e34fb..3f93f00b4e 100644 --- a/tools/cmake/build.cmake +++ b/tools/cmake/build.cmake @@ -127,7 +127,7 @@ endfunction() # function(__build_init idf_path) # Create the build target, to which the ESP-IDF build properties, dependencies are attached to - add_library(__idf_build_target STATIC IMPORTED) + add_library(__idf_build_target STATIC IMPORTED GLOBAL) set_default(python "python") From ba579d66bab45a13077aaeefc5a0ee0ab0c90bf7 Mon Sep 17 00:00:00 2001 From: Renz Christian Bagaporo Date: Mon, 18 May 2020 16:38:07 +0800 Subject: [PATCH 2/2] cmake: add comment that IDF build target must be global --- tools/cmake/build.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/cmake/build.cmake b/tools/cmake/build.cmake index 3f93f00b4e..d990b6951f 100644 --- a/tools/cmake/build.cmake +++ b/tools/cmake/build.cmake @@ -1,4 +1,3 @@ - # idf_build_get_property # # @brief Retrieve the value of the specified property related to ESP-IDF build. @@ -126,7 +125,8 @@ endfunction() # properties used for the processing phase of the build. # function(__build_init idf_path) - # Create the build target, to which the ESP-IDF build properties, dependencies are attached to + # Create the build target, to which the ESP-IDF build properties, dependencies are attached to. + # Must be global so as to be accessible from any subdirectory in custom projects. add_library(__idf_build_target STATIC IMPORTED GLOBAL) set_default(python "python")