From 5a8e9ef2bc376883b7c0dc5eb14d7cb34c9cb084 Mon Sep 17 00:00:00 2001 From: Angus Gratton Date: Wed, 31 Mar 2021 17:36:50 +1100 Subject: [PATCH] cmake: Improve the error message if the Python interpreter fails to run RESULT_VARIABLE will return a string not a number in this case, so display it for the user. --- tools/cmake/build.cmake | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/cmake/build.cmake b/tools/cmake/build.cmake index a6202025b0..de7be4d5a7 100644 --- a/tools/cmake/build.cmake +++ b/tools/cmake/build.cmake @@ -275,8 +275,12 @@ function(__build_check_python) message(STATUS "Checking Python dependencies...") execute_process(COMMAND "${python}" "${idf_path}/tools/check_python_dependencies.py" RESULT_VARIABLE result) - if(NOT result EQUAL 0) + if(result EQUAL 1) + # check_python_dependencies returns error code 1 on failure message(FATAL_ERROR "Some Python dependencies must be installed. Check above message for details.") + elseif(NOT result EQUAL 0) + # means check_python_dependencies.py failed to run at all, result should be an error message + message(FATAL_ERROR "Failed to run Python dependency check. Python: ${python}, Error: ${result}") endif() endif() endfunction()