mirror
/
esp-idf
kopia lustrzana https://github.com/espressif/esp-idf
1
0
Forkuj 0
Kod Zgłoszenia Projekty Wydania Wiki Aktywność

fix(ledc): fix ledc driver coverity issues

master
Song Ruo Jing 2024-12-05 11:39:44 +08:00
rodzic 11902d1a6f
commit 1e3dbeb6a8
1 zmienionych plików z 2 dodań i 1 usunięć
Pokaż statystyki Ściągnij plik aktualizacji Ściągnij plik porównania Expand all files Collapse all files

3
components/esp_driver_ledc/src/ledc.c
Wyświetl plik

@ -1335,6 +1335,7 @@ static esp_err_t _ledc_set_fade_with_step(ledc_mode_t speed_mode, ledc_channel_t
ledc_hal_get_duty(&(p_ledc_obj[speed_mode]->ledc_hal), channel, &duty_cur); ledc_hal_get_duty(&(p_ledc_obj[speed_mode]->ledc_hal), channel, &duty_cur);
// When duty == max_duty, meanwhile, if scale == 1 and fade_down == 1, counter would overflow. // When duty == max_duty, meanwhile, if scale == 1 and fade_down == 1, counter would overflow.
if (duty_cur == ledc_get_max_duty(speed_mode, channel)) { if (duty_cur == ledc_get_max_duty(speed_mode, channel)) {
assert(duty_cur > 0);
duty_cur -= 1; duty_cur -= 1;
} }
s_ledc_fade_rec[speed_mode][channel]->speed_mode = speed_mode; s_ledc_fade_rec[speed_mode][channel]->speed_mode = speed_mode;
@ -1776,7 +1777,7 @@ esp_err_t ledc_fill_multi_fade_param_list(ledc_mode_t speed_mode, ledc_channel_t
} }
surplus_cycles_last_phase = cycles_per_phase - step * cycle; surplus_cycles_last_phase = cycles_per_phase - step * cycle;
// If next phase is the last one, then account for all remaining duty and cycles // If next phase is the last one, then account for all remaining duty and cycles
if (i == linear_phase_num - 2) { if (linear_phase_num >= 2 && i == linear_phase_num - 2) {
phase_tail = end_duty; phase_tail = end_duty;
surplus_cycles_last_phase += total_cycles - avg_cycles_per_phase * linear_phase_num; surplus_cycles_last_phase += total_cycles - avg_cycles_per_phase * linear_phase_num;
} }