From 17273066453d304df6b8574db1810029f7b5f84b Mon Sep 17 00:00:00 2001 From: Ivan Grokhotkov Date: Mon, 8 Jun 2020 18:14:39 +0200 Subject: [PATCH] tools: fix diagnostic output in check_python_dependencies.py If IDF_PYTHON_ENV_PATH was not set, an exception occurred: Traceback (most recent call last): File "/home/user/esp/esp-idf/tools/check_python_dependencies.py", line 108, in if idf_python_env_path not in sys.executable: TypeError: 'in ' requires string as left operand, not NoneType and the final line in the diagnostic message was not printed. Fix to print the PATH if IDF_PYTHON_ENV_PATH is not set. --- tools/check_python_dependencies.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/check_python_dependencies.py b/tools/check_python_dependencies.py index b402ee0d26..ab86999ea5 100755 --- a/tools/check_python_dependencies.py +++ b/tools/check_python_dependencies.py @@ -105,7 +105,7 @@ if __name__ == "__main__": idf_python_env_path = os.environ.get('IDF_PYTHON_ENV_PATH') print(' IDF_PYTHON_ENV_PATH: {}'.format(idf_python_env_path or '(not set)')) print(' Python interpreter used: {}'.format(sys.executable)) - if idf_python_env_path not in sys.executable: + if not idf_python_env_path or idf_python_env_path not in sys.executable: print(' Warning: python interpreter not running from IDF_PYTHON_ENV_PATH') print(' PATH: {}'.format(os.getenv('PATH'))) sys.exit(1)