Merge branch 'bugfix/do_not_allow_unauthenticated_encrypted_key_data' into 'master'

esp_wifi: Ignore unauthenticated encrypted EAPOL-Key data

Closes IDFGH-6773

See merge request espressif/esp-idf!17105
pull/8812/head
Hrudaynath Dhabe 2022-04-20 16:32:45 +08:00
commit 079b5b1857
1 zmienionych plików z 13 dodań i 2 usunięć

Wyświetl plik

@ -1129,7 +1129,7 @@ static void wpa_sm_set_seq(struct wpa_sm *sm, struct wpa_eapol_key *key, u8 ispt
os_bzero(null_rsc, WPA_KEY_RSC_LEN);
if (sm->proto == WPA_PROTO_RSN) {
if (sm->proto == WPA_PROTO_RSN && isptk) {
key_rsc = null_rsc;
} else {
key_rsc = key->key_rsc;
@ -1979,7 +1979,18 @@ int wpa_sm_rx_eapol(u8 *src_addr, u8 *buf, u32 len)
}
if (sm->proto == WPA_PROTO_RSN &&
(key_info & WPA_KEY_INFO_ENCR_KEY_DATA)) {
(key_info & WPA_KEY_INFO_ENCR_KEY_DATA) && mic_len) {
/*
* Only decrypt the Key Data field if the frame's authenticity
* was verified. When using AES-SIV (FILS), the MIC flag is not
* set, so this check should only be performed if mic_len != 0
* which is the case in this code branch.
*/
if (!(key_info & WPA_KEY_INFO_MIC)) {
wpa_msg(sm->ctx->msg_ctx, MSG_WARNING,
"WPA: Ignore EAPOL-Key with encrypted but unauthenticated data");
goto out;
}
if (wpa_supplicant_decrypt_key_data(sm, key, ver, key_data,
&key_data_len))
goto out;