From 650dd607de87838ecaad8e68e3a604f31bc38008 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Mon, 23 Nov 2020 10:39:41 +0100 Subject: [PATCH 1/2] ci: Fixed wrong socket operation in python3 --- tools/test_apps/protocols/pppos/app_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/test_apps/protocols/pppos/app_test.py b/tools/test_apps/protocols/pppos/app_test.py index 818fe17f5e..acf23683c1 100644 --- a/tools/test_apps/protocols/pppos/app_test.py +++ b/tools/test_apps/protocols/pppos/app_test.py @@ -76,7 +76,7 @@ def test_examples_protocol_pppos_connect(env, extra_data): af, socktype, proto, canonname, addr = res sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM) sock.connect(addr) - sock.sendall("Espressif") + sock.sendall(b"Espressif") sock.close() dut1.expect(re.compile(r"IPv6 test passed")) From 8bd758b72ae8315e82659e7bde97569d4c7ea035 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Wed, 25 Nov 2020 21:21:03 +0100 Subject: [PATCH 2/2] ci: Removed remaining binary size checks in app-tests Also removes unused references to http-request app size in idf_performance.h --- components/idf_test/include/idf_performance.h | 3 --- .../test_apps/protocols/mqtt/publish_connect_test/app_test.py | 1 - tools/test_apps/protocols/openssl/app_test.py | 1 - 3 files changed, 5 deletions(-) diff --git a/components/idf_test/include/idf_performance.h b/components/idf_test/include/idf_performance.h index 5b0b91e1da..0dc7752668 100644 --- a/components/idf_test/include/idf_performance.h +++ b/components/idf_test/include/idf_performance.h @@ -7,9 +7,6 @@ * above. Forgetting this will produce compile-time warnings. */ -#ifndef IDF_PERFORMANCE_MAX_HTTPS_REQUEST_BIN_SIZE -#define IDF_PERFORMANCE_MAX_HTTPS_REQUEST_BIN_SIZE 900 -#endif #ifndef IDF_PERFORMANCE_MAX_FREERTOS_SPINLOCK_CYCLES_PER_OP #define IDF_PERFORMANCE_MAX_FREERTOS_SPINLOCK_CYCLES_PER_OP 200 #endif diff --git a/tools/test_apps/protocols/mqtt/publish_connect_test/app_test.py b/tools/test_apps/protocols/mqtt/publish_connect_test/app_test.py index 84187750f5..6b4b6fe613 100644 --- a/tools/test_apps/protocols/mqtt/publish_connect_test/app_test.py +++ b/tools/test_apps/protocols/mqtt/publish_connect_test/app_test.py @@ -143,7 +143,6 @@ def test_app_protocol_mqtt_publish_connect(env, extra_data): binary_file = os.path.join(dut1.app.binary_path, "mqtt_publish_connect_test.bin") bin_size = os.path.getsize(binary_file) ttfw_idf.log_performance("mqtt_publish_connect_test_bin_size", "{}KB".format(bin_size // 1024)) - ttfw_idf.check_performance("mqtt_publish_connect_test_bin_size_vin_size", bin_size // 1024, dut1.TARGET) # Look for test case symbolic names cases = {} try: diff --git a/tools/test_apps/protocols/openssl/app_test.py b/tools/test_apps/protocols/openssl/app_test.py index bbbfbdea0c..7ed325b55a 100644 --- a/tools/test_apps/protocols/openssl/app_test.py +++ b/tools/test_apps/protocols/openssl/app_test.py @@ -85,7 +85,6 @@ def test_app_esp_openssl(env, extra_data): binary_file = os.path.join(dut1.app.binary_path, "openssl_connect_test.bin") bin_size = os.path.getsize(binary_file) ttfw_idf.log_performance("openssl_connect_test_bin_size", "{}KB".format(bin_size // 1024)) - ttfw_idf.check_performance("openssl_connect_test_bin_size_vin_size", bin_size // 1024, dut1.TARGET) dut1.start_app() esp_ip = dut1.expect(re.compile(r" IPv4 address: ([0-9]+\.[0-9]+\.[0-9]+\.[0-9]+)"), timeout=30) print("Got IP={}".format(esp_ip[0]))