From 907d9999dcc189f619bc3599d04869b404a074f0 Mon Sep 17 00:00:00 2001
From: Ayo Ayco <ramon.aycojr@gmail.com>
Date: Wed, 6 Sep 2023 11:13:16 +0200
Subject: [PATCH] feat: filter notifications by type (#2371)

Co-authored-by: Xabi <xabi.rn@gmail.com>
Co-authored-by: userquin <userquin@gmail.com>
---
 components/common/CommonRouteTabs.vue         | 51 ++++++++++++++++-
 components/notification/NotificationCard.vue  |  4 +-
 components/timeline/TimelineMentions.vue      | 12 ----
 components/timeline/TimelineNotifications.vue | 10 +++-
 composables/notification.ts                   | 20 +++++++
 constants/index.ts                            |  4 ++
 locales/en.json                               | 12 ++++
 pages/notifications.vue                       | 55 +++++++++++++++++--
 pages/notifications/[filter].vue              | 24 ++++++++
 pages/notifications/mention.vue               | 10 ----
 10 files changed, 171 insertions(+), 31 deletions(-)
 delete mode 100644 components/timeline/TimelineMentions.vue
 create mode 100644 composables/notification.ts
 create mode 100644 pages/notifications/[filter].vue
 delete mode 100644 pages/notifications/mention.vue

diff --git a/components/common/CommonRouteTabs.vue b/components/common/CommonRouteTabs.vue
index e0eefc4f..95a994d1 100644
--- a/components/common/CommonRouteTabs.vue
+++ b/components/common/CommonRouteTabs.vue
@@ -1,6 +1,8 @@
 <script setup lang="ts">
 import type { RouteLocationRaw } from 'vue-router'
 
+const { t } = useI18n()
+
 export interface CommonRouteTabOption {
   to: RouteLocationRaw
   display: string
@@ -8,9 +10,17 @@ export interface CommonRouteTabOption {
   name?: string
   icon?: string
   hide?: boolean
+  match?: boolean
 }
-const { options, command, replace, preventScrollTop = false } = $defineProps<{
+export interface CommonRouteTabMoreOption {
   options: CommonRouteTabOption[]
+  icon?: string
+  tooltip?: string
+  match?: boolean
+}
+const { options, command, replace, preventScrollTop = false, moreOptions } = $defineProps<{
+  options: CommonRouteTabOption[]
+  moreOptions?: CommonRouteTabMoreOption
   command?: boolean
   replace?: boolean
   preventScrollTop?: boolean
@@ -21,7 +31,6 @@ const router = useRouter()
 useCommands(() => command
   ? options.map(tab => ({
     scope: 'Tabs',
-
     name: tab.display,
     icon: tab.icon ?? 'i-ri:file-list-2-line',
     onActivate: () => router.replace(tab.to),
@@ -51,5 +60,43 @@ useCommands(() => command
         <span ws-nowrap mxa sm:px2 sm:py3 py2 text-center text-secondary-light op50>{{ option.display }}</span>
       </div>
     </template>
+    <template v-if="moreOptions?.options?.length">
+      <CommonDropdown placement="bottom" flex cursor-pointer mx-1.25rem>
+        <CommonTooltip placement="top" :content="moreOptions.tooltip || t('action.more')">
+          <button
+            cursor-pointer
+            flex
+            gap-1
+            w-12
+            rounded
+            hover:bg-active
+            btn-action-icon
+            op75
+            px4
+            group
+            :aria-label="t('action.more')"
+            :class="moreOptions.match ? 'text-primary' : 'text-secondary'"
+          >
+            <span v-if="moreOptions.icon" :class="moreOptions.icon" text-sm me--1 block />
+            <span i-ri:arrow-down-s-line text-sm me--1 block />
+          </button>
+        </CommonTooltip>
+        <template #popper>
+          <NuxtLink
+            v-for="(option, index) in moreOptions.options.filter(item => !item.hide)"
+            :key="option?.name || index"
+            :to="option.to"
+          >
+            <CommonDropdownItem>
+              <span flex="~ row" gap-x-4 items-center :class="option.match ? 'text-primary' : ''">
+                <span v-if="option.icon" :class="[option.icon, option.match ? 'text-primary' : 'text.secondary']" text-md me--1 block />
+                <span v-else block>&#160;</span>
+                <span>{{ option.display }}</span>
+              </span>
+            </CommonDropdownItem>
+          </NuxtLink>
+        </template>
+      </commondropdown>
+    </template>
   </div>
 </template>
diff --git a/components/notification/NotificationCard.vue b/components/notification/NotificationCard.vue
index 8f456f5d..6cc322e9 100644
--- a/components/notification/NotificationCard.vue
+++ b/components/notification/NotificationCard.vue
@@ -31,7 +31,7 @@ const { notification } = defineProps<{
     </template>
     <template v-else-if="notification.type === 'admin.sign_up'">
       <div flex p3 items-center bg-shaded>
-        <div i-ri:admin-fill me-1 color-purple />
+        <div i-ri:user-add-fill me-1 color-purple />
         <AccountDisplayName
           :account="notification.account"
           text-purple me-1 font-bold line-clamp-1 ws-pre-wrap break-all
@@ -58,7 +58,7 @@ const { notification } = defineProps<{
     </template>
     <template v-else-if="notification.type === 'follow_request'">
       <div flex ms-4 items-center class="-top-2.5" absolute inset-ie-2 px-2>
-        <div i-ri:user-follow-fill text-xl me-1 />
+        <div i-ri:user-shared-fill text-xl me-1 />
         <AccountInlineInfo :account="notification.account" me1 />
       </div>
       <!-- TODO: accept request -->
diff --git a/components/timeline/TimelineMentions.vue b/components/timeline/TimelineMentions.vue
deleted file mode 100644
index f3e4f043..00000000
--- a/components/timeline/TimelineMentions.vue
+++ /dev/null
@@ -1,12 +0,0 @@
-<script setup lang="ts">
-// Default limit is 20 notifications, and servers are normally caped to 30
-const paginator = useMastoClient().v1.notifications.list({ limit: 30, types: ['mention'] })
-const stream = $(useStreaming(client => client.v1.stream.streamUser()))
-
-const { clearNotifications } = useNotifications()
-onActivated(clearNotifications)
-</script>
-
-<template>
-  <NotificationPaginator v-bind="{ paginator, stream }" />
-</template>
diff --git a/components/timeline/TimelineNotifications.vue b/components/timeline/TimelineNotifications.vue
index 480c13b4..eb52eb1e 100644
--- a/components/timeline/TimelineNotifications.vue
+++ b/components/timeline/TimelineNotifications.vue
@@ -1,6 +1,14 @@
 <script setup lang="ts">
+import type { mastodon } from 'masto'
+
+const { filter } = defineProps<{
+  filter?: mastodon.v1.NotificationType
+}>()
+
+const options = { limit: 30, types: filter ? [filter] : [] }
+
 // Default limit is 20 notifications, and servers are normally caped to 30
-const paginator = useMastoClient().v1.notifications.list({ limit: 30 })
+const paginator = useMastoClient().v1.notifications.list(options)
 const stream = useStreaming(client => client.v1.stream.streamUser())
 
 const { clearNotifications } = useNotifications()
diff --git a/composables/notification.ts b/composables/notification.ts
new file mode 100644
index 00000000..2728a50a
--- /dev/null
+++ b/composables/notification.ts
@@ -0,0 +1,20 @@
+import type { mastodon } from 'masto'
+import { NOTIFICATION_FILTER_TYPES } from '~/constants'
+
+/**
+ * Typeguard to check if an object is a valid notification filter
+ * @param obj the object to be checked
+ * @returns boolean and assigns type to object if true
+ */
+export function isNotificationFilter(obj: unknown): obj is mastodon.v1.NotificationType {
+  return !!obj && NOTIFICATION_FILTER_TYPES.includes(obj as unknown as mastodon.v1.NotificationType)
+}
+
+/**
+ * Typeguard to check if an object is a valid notification
+ * @param obj the object to be checked
+ * @returns boolean and assigns type to object if true
+ */
+export function isNotification(obj: unknown): obj is mastodon.v1.NotificationType {
+  return !!obj && ['mention', ...NOTIFICATION_FILTER_TYPES].includes(obj as unknown as mastodon.v1.NotificationType)
+}
diff --git a/constants/index.ts b/constants/index.ts
index c7d28132..57884c8a 100644
--- a/constants/index.ts
+++ b/constants/index.ts
@@ -1,3 +1,5 @@
+import type { mastodon } from 'masto'
+
 export const APP_NAME = 'Elk'
 
 export const DEFAULT_POST_CHARS_LIMIT = 500
@@ -22,3 +24,5 @@ export const STORAGE_KEY_NOTIFICATION_POLICY = 'elk-notification-policy'
 export const STORAGE_KEY_PWA_HIDE_INSTALL = 'elk-pwa-hide-install'
 
 export const HANDLED_MASTO_URLS = /^(https?:\/\/)?([\w\d-]+\.)+\w+\/(@[@\w\d-\.]+)(\/objects)?(\/\d+)?$/
+
+export const NOTIFICATION_FILTER_TYPES: mastodon.v1.NotificationType[] = ['status', 'reblog', 'follow', 'follow_request', 'favourite', 'poll', 'update', 'admin.sign_up', 'admin.report']
diff --git a/locales/en.json b/locales/en.json
index f4203169..2f3a10ec 100644
--- a/locales/en.json
+++ b/locales/en.json
@@ -605,8 +605,20 @@
     "list": "List",
     "media": "Media",
     "news": "News",
+    "notifications_admin": {
+      "report": "Report",
+      "sign_up": "Sign-Up"
+    },
     "notifications_all": "All",
+    "notifications_favourite": "Favourite",
+    "notifications_follow": "Follow",
+    "notifications_follow_request": "Follow request",
     "notifications_mention": "Mention",
+    "notifications_more_tooltip": "Filter notifications by type",
+    "notifications_poll": "Poll",
+    "notifications_reblog": "Boost",
+    "notifications_status": "Status",
+    "notifications_update": "Update",
     "posts": "Posts",
     "posts_with_replies": "Posts & Replies"
   },
diff --git a/pages/notifications.vue b/pages/notifications.vue
index 5bf26ce1..df565219 100644
--- a/pages/notifications.vue
+++ b/pages/notifications.vue
@@ -1,10 +1,16 @@
 <script setup lang="ts">
-import type { CommonRouteTabOption } from '~/components/common/CommonRouteTabs.vue'
+import type { mastodon } from 'masto'
+import { NOTIFICATION_FILTER_TYPES } from '~/constants'
+import type {
+  CommonRouteTabMoreOption,
+  CommonRouteTabOption,
+} from '~/components/common/CommonRouteTabs.vue'
 
 definePageMeta({
   middleware: 'auth',
 })
 
+const route = useRoute()
 const { t } = useI18n()
 const pwaEnabled = useAppConfig().pwaEnabled
 
@@ -20,6 +26,47 @@ const tabs = $computed<CommonRouteTabOption[]>(() => [
     display: isHydrated.value ? t('tab.notifications_mention') : '',
   },
 ])
+
+const filter = $computed<mastodon.v1.NotificationType | undefined>(() => {
+  if (!isHydrated.value)
+    return undefined
+
+  const rawFilter = route.params?.filter
+  const actualFilter = Array.isArray(rawFilter) ? rawFilter[0] : rawFilter
+  if (isNotificationFilter(actualFilter))
+    return actualFilter
+})
+
+const filterIconMap: Record<mastodon.v1.NotificationType, string> = {
+  'mention': 'i-ri:at-line',
+  'status': 'i-ri:account-pin-circle-line',
+  'reblog': 'i-ri:repeat-fill',
+  'follow': 'i-ri:user-follow-line',
+  'follow_request': 'i-ri:user-shared-line',
+  'favourite': 'i-ri:heart-3-line',
+  'poll': 'i-ri:chat-poll-line',
+  'update': 'i-ri:edit-2-line',
+  'admin.sign_up': 'i-ri:user-add-line',
+  'admin.report': 'i-ri:flag-line',
+}
+
+const filterText = $computed(() => (`${t('tab.notifications_more_tooltip')}${filter ? `: ${t(`tab.notifications_${filter}`)}` : ''}`))
+
+const notificationFilterRoutes = $computed<CommonRouteTabOption[]>(() => NOTIFICATION_FILTER_TYPES.map(
+  name => ({
+    name,
+    to: `/notifications/${name}`,
+    display: isHydrated.value ? t(`tab.notifications_${name}`) : '',
+    icon: filterIconMap[name],
+    match: name === filter,
+  }),
+))
+const moreOptions = $computed<CommonRouteTabMoreOption>(() => ({
+  options: notificationFilterRoutes,
+  icon: 'i-ri:filter-2-line',
+  tooltip: filterText,
+  match: !!filter,
+}))
 </script>
 
 <template>
@@ -27,7 +74,7 @@ const tabs = $computed<CommonRouteTabOption[]>(() => [
     <template #title>
       <NuxtLink to="/notifications" timeline-title-style flex items-center gap-2 @click="$scrollToTop">
         <div i-ri:notification-4-line />
-        <span>{{ t('nav.notifications') }}</span>
+        <span>{{ isHydrated ? t('nav.notifications') : '' }}</span>
       </NuxtLink>
     </template>
 
@@ -35,7 +82,7 @@ const tabs = $computed<CommonRouteTabOption[]>(() => [
       <NuxtLink
         flex rounded-4 p1
         hover:bg-active cursor-pointer transition-100
-        :title="t('settings.notifications.show_btn')"
+        :title="isHydrated ? t('settings.notifications.show_btn') : ''"
         to="/settings/notifications"
       >
         <span aria-hidden="true" i-ri:notification-badge-line />
@@ -43,7 +90,7 @@ const tabs = $computed<CommonRouteTabOption[]>(() => [
     </template>
 
     <template #header>
-      <CommonRouteTabs replace :options="tabs" />
+      <CommonRouteTabs replace :options="tabs" :more-options="moreOptions" />
     </template>
 
     <slot>
diff --git a/pages/notifications/[filter].vue b/pages/notifications/[filter].vue
new file mode 100644
index 00000000..9834c20d
--- /dev/null
+++ b/pages/notifications/[filter].vue
@@ -0,0 +1,24 @@
+<script setup lang="ts">
+import type { mastodon } from 'masto'
+
+const route = useRoute()
+const { t } = useI18n()
+
+const filter = $computed<mastodon.v1.NotificationType | undefined>(() => {
+  if (!isHydrated.value)
+    return undefined
+
+  const rawFilter = route.params?.filter
+  const actualFilter = Array.isArray(rawFilter) ? rawFilter[0] : rawFilter
+  if (isNotification(actualFilter))
+    return actualFilter
+})
+
+useHydratedHead({
+  title: () => `${t(`tab.notifications_${filter ?? 'all'}`)} | ${t('nav.notifications')}`,
+})
+</script>
+
+<template>
+  <TimelineNotifications v-if="isHydrated" :filter="filter" />
+</template>
diff --git a/pages/notifications/mention.vue b/pages/notifications/mention.vue
deleted file mode 100644
index e65a7522..00000000
--- a/pages/notifications/mention.vue
+++ /dev/null
@@ -1,10 +0,0 @@
-<script setup lang="ts">
-const { t } = useI18n()
-useHydratedHead({
-  title: () => `${t('tab.notifications_mention')} | ${t('nav.notifications')}`,
-})
-</script>
-
-<template>
-  <TimelineMentions v-if="isHydrated" />
-</template>