From 83db9f0c388087cbb73e0aa60312898fb86d9acb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=89=E5=92=B2=E6=99=BA=E5=AD=90?= <sxzz@sxzz.moe>
Date: Mon, 9 Jan 2023 20:23:15 +0800
Subject: [PATCH] fix: group follow notification

append current group before push a single item
---
 components/common/CommonPaginator.vue         | 14 ++--
 .../notification/NotificationPaginator.vue    | 69 ++++++++-----------
 composables/paginator.ts                      |  4 +-
 types/index.ts                                |  2 +-
 4 files changed, 37 insertions(+), 52 deletions(-)

diff --git a/components/common/CommonPaginator.vue b/components/common/CommonPaginator.vue
index 2cd07162..9e40c706 100644
--- a/components/common/CommonPaginator.vue
+++ b/components/common/CommonPaginator.vue
@@ -1,4 +1,4 @@
-<script setup lang="ts" generic="T, O">
+<script setup lang="ts" generic="T, O, U = T">
 // @ts-expect-error missing types
 import { DynamicScroller } from 'vue-virtual-scroller'
 import 'vue-virtual-scroller/dist/vue-virtual-scroller.css'
@@ -22,20 +22,20 @@ const {
   // until the next pagination to avoid border effect between pages when reordering
   // and grouping items
   buffer?: number
-  preprocess?: (items: T[]) => any[]
+  preprocess?: (items: T[]) => U[]
 }>()
 
 defineSlots<{
   default: {
-    items: T[]
-    item: T
+    items: U[]
+    item: U
     index: number
     active?: boolean
-    older?: T
-    newer?: T // newer is undefined when index === 0
+    older?: U
+    newer?: U // newer is undefined when index === 0
   }
   items: {
-    items: T[]
+    items: U[]
   }
   updater: {
     number: number
diff --git a/components/notification/NotificationPaginator.vue b/components/notification/NotificationPaginator.vue
index 7764513e..2e071e36 100644
--- a/components/notification/NotificationPaginator.vue
+++ b/components/notification/NotificationPaginator.vue
@@ -1,12 +1,9 @@
 <script setup lang="ts">
-import { mastodon } from 'masto'
-import type { Paginator, WsEvents } from 'masto'
-// type used in <template>
-// eslint-disable-next-line @typescript-eslint/consistent-type-imports
-import type { GroupedAccountLike, GroupedLikeNotifications, GroupedNotifications, NotificationSlot } from '~/types'
+import type { Paginator, WsEvents, mastodon } from 'masto'
+import type { GroupedAccountLike, NotificationSlot } from '~/types'
 
 const { paginator, stream } = defineProps<{
-  paginator: Paginator<NotificationSlot[], mastodon.v1.ListNotificationsParams>
+  paginator: Paginator<mastodon.v1.Notification[], mastodon.v1.ListNotificationsParams>
   stream?: Promise<WsEvents>
 }>()
 
@@ -26,7 +23,7 @@ const groupId = (item: mastodon.v1.Notification): string => {
   return JSON.stringify(id)
 }
 
-function groupItems(items: mastodon.v1.Notification[]): NotificationSlot[] {
+function preprocess(items: mastodon.v1.Notification[]): NotificationSlot[] {
   const results: NotificationSlot[] = []
 
   let id = 0
@@ -43,21 +40,31 @@ function groupItems(items: mastodon.v1.Notification[]): NotificationSlot[] {
     // This normally happens when you transfer an account, if not, show
     // a big profile card for each follow
     if (group[0].type === 'follow') {
-      const toGroup = []
+      let groups: mastodon.v1.Notification[] = []
+
+      function newGroup() {
+        if (groups.length > 0) {
+          results.push({
+            id: `grouped-${id++}`,
+            type: 'grouped-follow',
+            items: groups,
+          })
+          groups = []
+        }
+      }
+
       for (const item of group) {
         const hasHeader = !item.account.header.endsWith('/original/missing.png')
-        if (hasHeader && (item.account.followersCount > 250 || (group.length === 1 && item.account.followersCount > 25)))
+        if (hasHeader && (item.account.followersCount > 250 || (group.length === 1 && item.account.followersCount > 25))) {
+          newGroup()
           results.push(item)
-        else
-          toGroup.push(item)
-      }
-      if (toGroup.length > 0) {
-        results.push({
-          id: `grouped-${id++}`,
-          type: `grouped-${group[0].type}`,
-          items: toGroup,
-        })
+        }
+        else {
+          groups.push(item)
+        }
       }
+
+      newGroup()
       return
     }
 
@@ -101,28 +108,6 @@ function groupItems(items: mastodon.v1.Notification[]): NotificationSlot[] {
   return results
 }
 
-function preprocess(items: NotificationSlot[]): NotificationSlot[] {
-  const flattenedNotifications: mastodon.v1.Notification[] = []
-  for (const item of items) {
-    if (item.type === 'grouped-reblogs-and-favourites') {
-      const group = item as GroupedLikeNotifications
-      for (const like of group.likes) {
-        if (like.reblog)
-          flattenedNotifications.push(like.reblog)
-        if (like.favourite)
-          flattenedNotifications.push(like.favourite)
-      }
-    }
-    else if (item.type.startsWith('grouped-')) {
-      flattenedNotifications.push(...(item as GroupedNotifications).items)
-    }
-    else {
-      flattenedNotifications.push(item as mastodon.v1.Notification)
-    }
-  }
-  return groupItems(flattenedNotifications)
-}
-
 const { clearNotifications } = useNotifications()
 const { formatNumber } = useHumanReadableNumber()
 </script>
@@ -143,12 +128,12 @@ const { formatNumber } = useHumanReadableNumber()
         />
         <NotificationGroupedLikes
           v-else-if="item.type === 'grouped-reblogs-and-favourites'"
-          :group="item as GroupedLikeNotifications"
+          :group="item"
           border="b base"
         />
         <NotificationCard
           v-else
-          :notification="item as mastodon.v1.Notification"
+          :notification="item"
           hover:bg-active
           border="b base"
         />
diff --git a/composables/paginator.ts b/composables/paginator.ts
index debdd563..3e78f0b9 100644
--- a/composables/paginator.ts
+++ b/composables/paginator.ts
@@ -1,11 +1,11 @@
 import type { Paginator, WsEvents } from 'masto'
 import type { PaginatorState } from '~/types'
 
-export function usePaginator<T, P>(
+export function usePaginator<T, P, U = T>(
   paginator: Paginator<T[], P>,
   stream?: Promise<WsEvents>,
   eventType: 'notification' | 'update' = 'update',
-  preprocess: (items: T[]) => T[] = (items: T[]) => items,
+  preprocess: (items: T[]) => U[] = (items: T[]) => items as unknown as U[],
   buffer = 10,
 ) {
   const state = ref<PaginatorState>(isMastoInitialised.value ? 'idle' : 'loading')
diff --git a/types/index.ts b/types/index.ts
index 2320951f..42e044d8 100644
--- a/types/index.ts
+++ b/types/index.ts
@@ -29,7 +29,7 @@ export type PaginatorState = 'idle' | 'loading' | 'done' | 'error'
 
 export interface GroupedNotifications {
   id: string
-  type: Exclude<string, 'grouped-reblogs-and-favourites'>
+  type: 'grouped-follow'
   items: mastodon.v1.Notification[]
 }