From 1e5db5ad8719c7ad191ade9b46c938b2a4a979d1 Mon Sep 17 00:00:00 2001
From: Ahmed Badra <42746335+badra069@users.noreply.github.com>
Date: Mon, 21 Jun 2021 07:12:13 +0200
Subject: [PATCH] some bugs in allpass additon

---
 index.html | 50 +++++++++++++++++++++++++++++---------------------
 style.css  | 31 ++++++++++++++++---------------
 2 files changed, 45 insertions(+), 36 deletions(-)

diff --git a/index.html b/index.html
index cbdd776..3a91f19 100644
--- a/index.html
+++ b/index.html
@@ -17,16 +17,17 @@
       <button class="button-menu"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 385 385">
           <path d="M12 120.3h361a12 12 0 000-24H12a12 12 0 000 24zM373 180.5H12a12 12 0 000 24h361a12 12 0 000-24zM373 264.7H132.2a12 12 0 000 24H373a12 12 0 000-24z" />
         </svg></button>
-      <input type="search" placeholder="Search Documentation..." />
+      <!-- <input type="search" placeholder="Search Documentation..." /> -->
     </div>
   </div>
   <div class="main">
     <div class="sidebar">
       <ul>
-        <li><a href="#"><i class="lni lni-text-format"></i><span>a = 2 + 2j</span></a></li>
-        <li><a href="#"><i class="lni lni-text-format"></i><span>a = 2 - 2j</span></a></li>
-        <li><a href="#"><i class="lni lni-text-format"></i><span>a = 1 + 2j</span></a></li>
-        <li><a href="#"><i class="lni lni-text-format"></i><span>a = 2 + 1j</span></a></li>
+        <li><a href="#" onclick="showZplaneForAllPass('2 + 2i')" ondblclick="addNewAllPass('2 + 2j')"><i class="lni lni-text-format"></i><span>a = 2 + 2j</span></a></li>
+        <li><a href="#" onclick="showZplaneForAllPass('2 - 2i')" ondblclick="addNewAllPass('2 - 2j')"><i class="lni lni-text-format" ></i><span>a = 2 - 2j</span></a></li>
+        <li><a href="#" onclick="showZplaneForAllPass('1 + 2i')" ondblclick="addNewAllPass('1 + 2j')"><i class="lni lni-text-format" ></i><span>a = 1 + 2j</span></a></li>
+        <li><a href="#" onclick="showZplaneForAllPass('2 + 1i')" ondblclick="addNewAllPass('2 + 1j')"><i class="lni lni-text-format" ></i><span>a = 2 + 1j</span></a></li>
+        <li><a href="#"><i class="lni lni-text-format" onclick="addNewAllPassParameter()"></i><span>add New...</span></a></li>        
       </ul>
     </div>
     <div class="page-content">
@@ -42,13 +43,24 @@
         <label> add Conjugates</label>
         <input type="checkbox" id="allPassEffect" onclick="setZplane(poles, zeros)">
         <label> with all Pass filters</label>
-        <div id="design_responses">
-            <div id="mag_response" style="width:500px;height:200px;"></div>
-            <div id="phase_response" style="width:500px;height:200px;"></div>
-        </div>
+    </div>
+    <div id="design_responses">
+        <div id="mag_response" style="width:500px;height:200px;"></div>
+        <div id="phase_response" style="width:500px;height:200px;"></div>
+    </div>
+  </div>  
+</div>
+<div id="allpass">
+    <div>
+      <canvas id="allpass_zplane_polezero2" width=300 height=300></canvas>
+    </div>
+    <div>
+      <div id="allpass_phase_response" style="width:600px;height:300px;"></div>
+    </div>
+    <div>
+      <label>a = </label><input type="text" id="NewAllPassValue">
     </div>
   </div>
-</div>
 
 <script src="layout.js" type="text/javascript"></script>
 <script>
@@ -375,9 +387,9 @@ function setZplane(poles, zeros) {
 }
 
 function showZplaneForAllPass(a) {
-    let zero = math.divide(1, math.conj(math.complex(a)));
+    let zero = math.divide(math.complex(1,0), math.conj(math.complex(a)));
     let pole = math.complex(a);
-    var radius = 100;	// radius of unit circle
+    var radius = 50;	// radius of unit circle
     var pSize = 4;		// size of pole and zero graphic
     var zSize = 4;
 
@@ -427,12 +439,12 @@ function showZplaneForAllPass(a) {
     ctx.arc(x + pad, y + pad, zSize, 0, 2*Math.PI);
     ctx.stroke();
 
-    drawResponseOfAllPass(math.complex(a));
+    drawResponseOfAllPass(a);
 }
 
-function drawResponseOfAllPass() {
-    let zero = math.divide(1, math.conj(a));
-    let pole = a;
+function drawResponseOfAllPass(a) {
+    let zero = math.divide(1, math.conj(math.complex(a)));
+    let pole = math.complex(a);
     let magResponse = [];
     let phaseResponse = [];
     for(let i = 0; i < 100; i++){
@@ -466,14 +478,10 @@ function drawResponseOfAllPass() {
         phaseData.push([freqAxis[i], phaseResponse[i]]);
         // console.log(phaseResponse[i]);
     }
-
-    // plot mag_response
-	var container = document.getElementById('allpass_mag_response');
-    graph = Flotr.draw(container, [ magData ], { yaxis: { max : 10, min : 0 } });
     
     // plot phase_response
     var container = document.getElementById('allpass_phase_response');
-    graph = Flotr.draw(container, [ phaseData ], { yaxis: { max : 120, min : -120 } });
+    graph = Flotr.draw(container, [ phaseData ], { yaxis: { max : 60, min : -60 } });
 }
 
 function drawResponses() {
diff --git a/style.css b/style.css
index 722a538..9bfbfa5 100644
--- a/style.css
+++ b/style.css
@@ -8,10 +8,11 @@
   }
   .container {
     display: flex;
-    height: 100vh;
+    height: 70vh;
     width: 100vw;
     flex-wrap: wrap;
     overflow: hidden;
+
   }
   .main {
     height: calc(100% - 50px);
@@ -95,18 +96,6 @@
     width: 100%;
     flex: 1;
   }
-  .page-content h1 {
-    font-size: 20px;
-    font-weight: 400;
-    color: #333;
-  }
-  .header-search {
-    height: 100%;
-    align-items: center;
-    display: flex;
-    padding: 0 20px;
-    flex: 1;
-  }
   .header-search .button-menu {
     width: 28px;
     height: 28px;
@@ -159,6 +148,18 @@
 
 #zplane_polezero2{border:2px solid black;}
 
-#design_responses {
-    
+#allpass {
+    background-color: #e8ecef;
+    display: flex;
+    height: 60vh;
+    width: 100vw;
+    margin-left: 240px;
+    flex-wrap: wrap;
+    flex-direction: column;
+    overflow: hidden;
+    justify-content: space-between;
+}
+
+#allpass div {
+    justify-content: center;
 }
\ No newline at end of file