From ec2db345e9465ee4ce3880dc62dcd453e66bcbca Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Sun, 5 May 2019 14:01:14 -0400 Subject: [PATCH] Fixed crash on /:memory: page --- datasette/app.py | 2 ++ tests/test_html.py | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/datasette/app.py b/datasette/app.py index 1d943233..2f0bf47a 100644 --- a/datasette/app.py +++ b/datasette/app.py @@ -149,6 +149,8 @@ class ConnectedDatabase: @property def size(self): + if self.is_memory: + return 0 if self.cached_size is not None: return self.cached_size else: diff --git a/tests/test_html.py b/tests/test_html.py index 71dfe722..b25263cb 100644 --- a/tests/test_html.py +++ b/tests/test_html.py @@ -19,6 +19,11 @@ def test_homepage(app_client): assert "fixtures" in response.text +def test_memory_database_page(app_client_with_memory): + response = app_client_with_memory.get("/:memory:") + assert response.status == 200 + + def test_database_page_redirects_with_url_hash(app_client_with_hash): response = app_client_with_hash.get("/fixtures", allow_redirects=False) assert response.status == 302