From d348dfe74d7738a7389345f9e12e7545e6fe6a9a Mon Sep 17 00:00:00 2001 From: Cameron Yick Date: Sun, 2 Apr 2023 13:39:15 -0400 Subject: [PATCH] refactor: rename the dropdown icon in table.js --- datasette/static/table.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/datasette/static/table.js b/datasette/static/table.js index 2c309158..66107cf4 100644 --- a/datasette/static/table.js +++ b/datasette/static/table.js @@ -217,10 +217,11 @@ const initDatasetteTable = function (manager) { }); } - var svg = document.createElement("div"); - svg.innerHTML = DROPDOWN_ICON_SVG; - svg = svg.querySelector("*"); - svg.classList.add("dropdown-menu-icon"); + + var dropdownIcon = document.createElement("div"); + dropdownIcon.innerHTML = DROPDOWN_ICON_SVG; + dropdownIcon = dropdownIcon.querySelector("*"); + dropdownIcon.classList.add("dropdown-menu-icon"); var menu = document.createElement("div"); menu.innerHTML = DROPDOWN_HTML; menu = menu.querySelector("*"); @@ -233,7 +234,7 @@ const initDatasetteTable = function (manager) { if (!th.querySelector("a")) { return; } - var icon = svg.cloneNode(true); + var icon = dropdownIcon.cloneNode(true); icon.addEventListener("click", onTableHeaderClick); th.appendChild(icon); });