Merge b3156107d7 into d87bd12dbc

datasette/utils/asgi.py

@@ -2,7 +2,7 @@ import hashlib
 import json
 from datasette.utils import MultiParams, calculate_etag
 from mimetypes import guess_type
-from urllib.parse import parse_qs, urlunparse, parse_qsl
+from urllib.parse import parse_qs, urlunparse, parse_qsl, unquote
 from pathlib import Path
 from http.cookies import SimpleCookie, Morsel
 import aiofiles
@@ -318,7 +318,7 @@ def asgi_static(root_path, chunk_size=4096, headers=None, content_type=None):
         path = request.scope["url_route"]["kwargs"]["path"]
         headers = static_headers.copy()
         try:
-            full_path = (root_path / path).resolve().absolute()
+            full_path = (root_path / unquote(path)).resolve().absolute()
         except FileNotFoundError:
             await asgi_send_html(send, "404: Directory not found", 404)
             return

tests/test_html.py

@@ -115,6 +115,14 @@ def test_static_mounts():
     ) as client:
         response = client.get("/custom-static/test_html.py")
         assert response.status_code == 200
+        response = client.get(
+            "/custom-static/test_templates/pages/nested/filename with spaces"
+        )
+        assert response.status_code == 200
+        response = client.get(
+            "/custom-static/test_templates/pages/topic_{topic}/{slug}.html"
+        )
+        assert response.status_code == 200
         response = client.get("/custom-static/not_exists.py")
         assert response.status_code == 404
         response = client.get("/custom-static/../LICENSE")