diff --git a/datasette/static/datasette-manager.js b/datasette/static/datasette-manager.js index d3399ae6..5422489a 100644 --- a/datasette/static/datasette-manager.js +++ b/datasette/static/datasette-manager.js @@ -16,7 +16,7 @@ const DOM_SELECTORS = { aboveTablePanel: '.above-table-panel', // These could have multiple matches - /** Used for selecting table headers. Use getColumnActions if you want to add menu items. */ + /** Used for selecting table headers. Use makeColumnActions if you want to add menu items. */ tableHeaders: `table.rows-and-columns th`, /** Used to add "where" clauses to query using direct manipulation */ @@ -65,20 +65,22 @@ const datasetteManager = { * - columnType: sqlite datatype enum (text, number, etc) * - isPk: boolean */ - getColumnActions: (columnMeta) => { - let items = []; - // Accept function that returns list of items with keys + makeColumnActions: (columnMeta) => { + let columnActions = []; + + // Accept function that returns list of columnActions with keys // Required: label (text) // Optional: onClick or href datasetteManager.plugins.forEach(plugin => { - if (plugin.getColumnActions) { - // Plugins can provide multiple items if they want + if (plugin.makeColumnActions) { + // Plugins can provide multiple columnActions if they want // If multiple try to create entry with same label, the last one deletes the others - items.push(...plugin.getColumnActions(columnMeta)); + columnActions.push(...plugin.makeColumnActions(columnMeta)); } }); - // TODO: Validate item configs and give informative error message if missing keys. - return items; + + // TODO: Validate columnAction configs and give informative error message if missing keys. + return columnActions; }, /** diff --git a/datasette/static/table-example-plugins.js b/datasette/static/table-example-plugins.js index aa58509d..c0088c9b 100644 --- a/datasette/static/table-example-plugins.js +++ b/datasette/static/table-example-plugins.js @@ -15,7 +15,7 @@ const addPlugins = (manager) => { manager.registerPlugin("column-name-plugin", { version: 0.1, - getColumnActions: (columnMeta) => { + makeColumnActions: (columnMeta) => { const { column } = columnMeta; return [ diff --git a/datasette/static/table.js b/datasette/static/table.js index eaf9a64c..778457c5 100644 --- a/datasette/static/table.js +++ b/datasette/static/table.js @@ -194,7 +194,7 @@ const initDatasetteTable = function (manager) { columnType: th.dataset.columnType, isPk: th.dataset.isPk === '1' }; - const columnItemConfigs = manager.getColumnActions(columnActionsPayload); + const columnItemConfigs = manager.makeColumnActions(columnActionsPayload); const menuList = menu.querySelector('ul'); columnItemConfigs.forEach(itemConfig => {