From d8ec1f20c10adfacfcd5b1b37c2f4e02580a3f0e Mon Sep 17 00:00:00 2001 From: Neeraj Kashyap Date: Tue, 2 Aug 2022 05:53:12 -0700 Subject: [PATCH] Some TODOs --- dao/test_terminus.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/dao/test_terminus.py b/dao/test_terminus.py index cdfa236..96037af 100644 --- a/dao/test_terminus.py +++ b/dao/test_terminus.py @@ -743,6 +743,13 @@ class TestPoolOperations(TerminusTestCase): operator = accounts[2] user = accounts[3] + # TODO(zomglings): We should test the Terminus controller permissions on the same contract. + # Currently, controller is both pool controller AND Terminus controller. In a more proper test, + # these would be different accounts. + + # TODO(zomglings): Tested manually that changing burnable below from True to False results in + # the right reversion when we try to burn these tokens on-chain. This should be a separate + # test case that runs *automatically*. self.diamond_terminus.create_pool_v1(100, True, True, {"from": controller}) pool_id = self.diamond_terminus.total_pools() self.diamond_terminus.mint( @@ -759,7 +766,7 @@ class TestPoolOperations(TerminusTestCase): operator_balance_0 = self.diamond_terminus.balance_of(operator.address, pool_id) user_balance_0 = self.diamond_terminus.balance_of(user.address, pool_id) - self.assertFalse(self.diamond_terminus.is_approved_for_pool(pool_id, operator)) + self.assertFalse(self.diamond_terminus.is_approved_for_pool(pool_id, operator.address)) with self.assertRaises(VirtualMachineError): self.diamond_terminus.mint( @@ -811,7 +818,7 @@ class TestPoolOperations(TerminusTestCase): self.diamond_terminus.approve_for_pool(pool_id, operator, {"from": accounts[1]}) - self.assertTrue(self.diamond_terminus.is_approved_for_pool(pool_id, operator)) + self.assertTrue(self.diamond_terminus.is_approved_for_pool(pool_id, operator.address)) self.diamond_terminus.mint( controller.address, pool_id, 1, "", {"from": operator} @@ -848,13 +855,13 @@ class TestPoolOperations(TerminusTestCase): pool_id, operator, {"from": operator} ) - self.assertTrue(self.diamond_terminus.is_approved_for_pool(pool_id, operator)) + self.assertTrue(self.diamond_terminus.is_approved_for_pool(pool_id, operator.address)) self.diamond_terminus.unapprove_for_pool( pool_id, operator, {"from": controller} ) - self.assertFalse(self.diamond_terminus.is_approved_for_pool(pool_id, operator)) + self.assertFalse(self.diamond_terminus.is_approved_for_pool(pool_id, operator.address)) with self.assertRaises(VirtualMachineError): self.diamond_terminus.mint(