From f17f39eb71059b29d0aeca9427613417e9ec7036 Mon Sep 17 00:00:00 2001 From: nyanpasu64 Date: Sat, 12 Mar 2022 02:04:22 -0800 Subject: [PATCH] Change default document settings * Set mean_responsiveness to 0. * Decrease default edge strength from 2.0 to 1.0. 2.0 seems to cause waves to lose track too often (but the optimum value varies by song). * Increase default slope width to 0.25 period. It seems to work better in general. You can adjust it on a case-by-case basis though. The default value when loading older files missing the key has also changed to 0.25, since slope width is now necessary for triggering instead of being added to edge triggering in special cases. * Set default "Reset Below Match" to 0.3. This level is harmless but not very useful (besides clearing the buffer upon silence, like all nonzero values). The optimal value varies wildly by song and "Buffer Responsiveness". --- corrscope/corrscope.py | 4 +++- corrscope/triggers.py | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/corrscope/corrscope.py b/corrscope/corrscope.py index df9d119..6b15290 100644 --- a/corrscope/corrscope.py +++ b/corrscope/corrscope.py @@ -118,7 +118,9 @@ def template_config(**kwargs) -> Config: trigger_subsampling=1, render_subsampling=2, trigger=CorrelationTriggerConfig( - edge_strength=2, + mean_responsiveness=0.0, + edge_strength=1.0, + reset_below=0.3, responsiveness=0.5, pitch_tracking=SpectrumConfig(), # post_trigger=ZeroCrossingTriggerConfig(), diff --git a/corrscope/triggers.py b/corrscope/triggers.py index 333ebf3..b678bef 100644 --- a/corrscope/triggers.py +++ b/corrscope/triggers.py @@ -281,7 +281,7 @@ class CorrelationTriggerConfig( edge_strength: float # Slope detection - slope_width: float = with_units("period", default=0.07) + slope_width: float = with_units("period", default=0.25) # Correlation detection buffer_strength: float = 1