feat: improve HackerNews client

legacy/examples/playground/bin/scratch.ts

@@ -144,8 +144,17 @@ async function main() {
   // const res = await zoomInfo.searchContacts({
   //   fullName: 'Kevin Raheja'
   // })
-  const gravatar = new stdlib.GravatarClient()
+  // const gravatar = new stdlib.GravatarClient()
-  const res = await gravatar.getProfileByIdentifier('email@example.com')
+  // const res = await gravatar.getProfileByIdentifier('email@example.com')
+
+  const hn = new stdlib.HackerNewsClient()
+  // const res = await hn.getSearchItem('43201417')
+  const res = await hn.searchItems({
+    query: 'OpenAI',
+    tags: ['story'],
+    sortBy: 'recency',
+    numericFilters: ['points>1000']
+  })
 
   console.log(JSON.stringify(res, null, 2))
 }

legacy/packages/core/src/utils.ts

@@ -198,7 +198,12 @@ export function sanitizeSearchParams(
         string | number | boolean | string[] | number[] | boolean[] | undefined
       >
     | object,
-  { csv = false }: { csv?: boolean } = {}
+  {
+    csv = false
+  }: {
+    /** Whether or not to use comma-separated-values for arrays or multiple entries (the default) */
+    csv?: boolean
+  } = {}
 ): URLSearchParams {
   const entries = Object.entries(searchParams).flatMap(([key, value]) => {
     if (key === undefined || value === undefined) {

legacy/packages/gravatar/src/gravatar-client.ts

@@ -51,7 +51,7 @@ export namespace gravatar {
     /** The name of the company where the user is employed. */
     company: string
     /** An array of verified accounts the user has added to their profile. The number of verified accounts displayed is limited to a maximum of 4 in unauthenticated requests. */
-    verified_accounts: Account[]
+    verified_accounts: VerifiedAccount[]
     /** A phonetic guide to pronouncing the user’s name. */
     pronunciation: string
     /** The pronouns the user prefers to use. */
@@ -60,9 +60,9 @@ export namespace gravatar {
     is_organization?: boolean
     links?: Link[]
     interests?: any[]
-    gallery?: Image[]
+    gallery?: GalleryImage[]
     payments?: {
-      links?: any[]
+      links?: Link[]
       crypto_wallets?: CryptoWallet[]
     }
 
@@ -78,7 +78,7 @@ export namespace gravatar {
     contact_info?: ContactInfo
   }
 
-  export interface Account {
+  export interface VerifiedAccount {
     service_type: string
     service_label: string
     service_icon: string
@@ -91,7 +91,7 @@ export namespace gravatar {
     url: string
   }
 
-  export interface Image {
+  export interface GalleryImage {
     url: string
     alt_text: string
   }

legacy/packages/hacker-news/src/hacker-news-client.ts

@@ -1,7 +1,19 @@
-import { AIFunctionsProvider, assert, getEnv } from '@agentic/core'
+import {
+  aiFunction,
+  AIFunctionsProvider,
+  assert,
+  getEnv,
+  sanitizeSearchParams
+} from '@agentic/core'
 import defaultKy, { type KyInstance } from 'ky'
+import z from 'zod'
 
 export namespace hackernews {
+  export const HACKER_NEWS_API_BASE_URL = 'https://hacker-news.firebaseio.com'
+  export const HACKER_NEWS_API_SEARCH_BASE_URL = 'https://hn.algolia.com'
+  export const HACKER_NEWS_API_USER_AGENT =
+    'Agentic (https://github.com/transitive-bullshit/agentic)'
+
   export type ItemType =
     | 'story'
     | 'comment'
@@ -32,59 +44,333 @@ export namespace hackernews {
     karma: number
     submitted: number[]
   }
+
+  export type SearchTag =
+    | 'story'
+    | 'comment'
+    | 'poll'
+    | 'pollopt'
+    | 'show_hn'
+    | 'ask_hn'
+    | 'front_page'
+
+  export type SearchNumericFilterField =
+    | 'created_at_i'
+    | 'points'
+    | 'num_comments'
+  export type SearchNumericFilterCondition = '<' | '<=' | '=' | '>=' | '>'
+
+  export type SearchSortBy = 'relevance' | 'recency'
+
+  export interface SearchOptions {
+    /** Full-text search query */
+    query?: string
+
+    /** Filter by author's HN username */
+    author?: string
+
+    /** Filter by story id */
+    story?: string
+
+    /** Filter by type of item (story, comment, etc.) */
+    tags?: Array<SearchTag>
+
+    /** Filter by numeric range (created_at_i, points, or num_comments); (created_at_i is a timestamp in seconds) */
+    numericFilters?: Array<`${SearchNumericFilterField}${SearchNumericFilterCondition}${number}`>
+
+    /** Page number to return */
+    page?: number
+
+    /** Number of results to return per page */
+    hitsPerPage?: number
+
+    /** How to sort the results */
+    sortBy?: SearchSortBy
+  }
+
+  export interface SearchItem {
+    id: number
+    created_at: string
+    created_at_i: number
+    title?: string
+    url?: string
+    author: string
+    text: string | null
+    points: number | null
+    parent_id: number | null
+    story_id: number | null
+    type: ItemType
+    children: SearchItem[]
+    options?: any[]
+  }
+
+  export interface SearchUser {
+    username: string
+    about: string
+    karma: number
+  }
+
+  export interface SearchResponse {
+    hits: SearchHit[]
+    page: number
+    nbHits: number
+    nbPages: number
+    hitsPerPage: number
+    query: string
+    params: string
+    processingTimeMS: number
+    serverTimeMS: number
+    processingTimingsMS?: any
+  }
+
+  export interface SearchHit {
+    objectID: string
+    url: string
+    title: string
+    author: string
+    story_text?: string
+    story_id?: number
+    story_url?: string
+    comment_text?: string
+    points?: number
+    num_comments?: number
+    created_at: string
+    created_at_i: number
+    updated_at: string
+    parts?: number[]
+    children: number[]
+    _tags: string[]
+    _highlightResult: SearchHighlightResult
+  }
+
+  export interface SearchHighlightResult {
+    author: Highlight
+    title?: Highlight
+    url?: Highlight
+    comment_text?: Highlight
+    story_title?: Highlight
+    story_url?: Highlight
+  }
+
+  export interface Highlight {
+    value: string
+    matchLevel: string
+    matchedWords: string[]
+    fullyHighlighted?: boolean
+  }
+
+  export const searchTagSchema = z.union([
+    z.literal('story'),
+    z.literal('comment'),
+    z.literal('poll'),
+    z.literal('pollopt'),
+    z.literal('show_hn'),
+    z.literal('ask_hn'),
+    z.literal('front_page')
+  ])
+
+  export const searchSortBySchema = z.union([
+    z.literal('relevance'),
+    z.literal('recency')
+  ])
+
+  export const searchOptionsSchema = z.object({
+    query: z.string().optional().describe('Full-text search query'),
+    author: z.string().optional().describe("Filter by author's HN username"),
+    story: z.string().optional().describe('Filter by story id'),
+    tags: z
+      .array(hackernews.searchTagSchema)
+      .optional()
+      .describe(
+        "Filter by type of item (story, comment, etc.). Multiple tags are AND'ed together."
+      ),
+    numericFilters: z
+      .array(z.any())
+      .optional()
+      .describe(
+        'Filter by numeric range (created_at_i, points, or num_comments); (created_at_i is a timestamp in seconds). Ex: numericFilters=points>100,num_comments>=1000'
+      ),
+    page: z
+      .number()
+      .int()
+      .nonnegative()
+      .optional()
+      .describe('Page number to return'),
+    hitsPerPage: z
+      .number()
+      .int()
+      .positive()
+      .optional()
+      .describe('Number of results to return per page (defaults to 50)'),
+    sortBy: hackernews.searchSortBySchema
+      .optional()
+      .describe('How to sort the results (defaults to relevancy)')
+  })
 }
 
 /**
  * Basic client for the official Hacker News API.
  *
- * Note that the [HN Algolia API](https://hn.algolia.com/api) seems to no
+ * The normal API methods (`getItem`) use the official Firebase API, while the
- * longer be available, so we can't add search without quite a bit of overhead.
+ * search-prefixed methods use the more powerful Algolia API. The tradeoff is
+ * that the official Firebase API is generally more reliable in my experience,
+ * which is why we opted to support both.
  *
  * @see https://github.com/HackerNews/API
+ * @see https://hn.algolia.com/api
  */
 export class HackerNewsClient extends AIFunctionsProvider {
-  protected readonly ky: KyInstance
+  protected readonly apiKy: KyInstance
+  protected readonly apiSearchKy: KyInstance
+
   protected readonly apiBaseUrl: string
+  protected readonly apiSearchBaseUrl: string
   protected readonly apiUserAgent: string
 
   constructor({
     apiBaseUrl = getEnv('HACKER_NEWS_API_BASE_URL') ??
-      'https://hacker-news.firebaseio.com',
+      hackernews.HACKER_NEWS_API_BASE_URL,
+    apiSearchBaseUrl = getEnv('HACKER_NEWS_API_SEARCH_BASE_URL') ??
+      hackernews.HACKER_NEWS_API_SEARCH_BASE_URL,
     apiUserAgent = getEnv('HACKER_NEWS_API_USER_AGENT') ??
-      'Agentic (https://github.com/transitive-bullshit/agentic)',
+      hackernews.HACKER_NEWS_API_USER_AGENT,
-    ky = defaultKy
+    ky = defaultKy,
+    timeoutMs = 60_000
   }: {
     apiBaseUrl?: string
+    apiSearchBaseUrl?: string
     apiUserAgent?: string
     ky?: KyInstance
+    timeoutMs?: number
   } = {}) {
     assert(apiBaseUrl, 'HackerNewsClient missing required "apiBaseUrl"')
+    assert(
+      apiSearchBaseUrl,
+      'HackerNewsClient missing required "apiSearchBaseUrl"'
+    )
     super()
 
     this.apiBaseUrl = apiBaseUrl
+    this.apiSearchBaseUrl = apiSearchBaseUrl
     this.apiUserAgent = apiUserAgent
 
-    this.ky = ky.extend({
+    this.apiKy = ky.extend({
       prefixUrl: apiBaseUrl,
+      timeout: timeoutMs,
+      headers: {
+        'user-agent': apiUserAgent
+      }
+    })
+
+    this.apiSearchKy = ky.extend({
+      prefixUrl: apiSearchBaseUrl,
+      timeout: timeoutMs,
       headers: {
         'user-agent': apiUserAgent
       }
     })
   }
 
+  @aiFunction({
+    name: 'hacker_news_get_item',
+    description: 'Fetches a HN story or comment by its ID.',
+    inputSchema: z.object({ itemId: z.string() })
+  })
+  async getSearchItem(itemIdOrOpts: string | number | { itemId: string }) {
+    const { itemId } =
+      typeof itemIdOrOpts === 'string' || typeof itemIdOrOpts === 'number'
+        ? { itemId: itemIdOrOpts }
+        : itemIdOrOpts
+
+    return this.apiSearchKy
+      .get(`api/v1/items/${itemId}`)
+      .json<hackernews.SearchItem>()
+  }
+
+  @aiFunction({
+    name: 'hacker_news_get_user',
+    description: 'Fetches a HN user by username.',
+    inputSchema: z.object({ username: z.string() })
+  })
+  async getSearchUser(usernameOrOpts: string | number | { username: string }) {
+    const { username } =
+      typeof usernameOrOpts === 'string' || typeof usernameOrOpts === 'number'
+        ? { username: usernameOrOpts }
+        : usernameOrOpts
+
+    return this.apiSearchKy
+      .get(`api/v1/users/${username}`)
+      .json<hackernews.SearchUser>()
+  }
+
+  @aiFunction({
+    name: 'hacker_news_search',
+    description:
+      'Searches HN for stories and comments matching the given query.',
+    inputSchema: hackernews.searchOptionsSchema
+  })
+  async searchItems(queryOrOpts: string | hackernews.SearchOptions) {
+    const {
+      query,
+      numericFilters,
+      page,
+      hitsPerPage,
+      sortBy = 'relevance',
+      ...opts
+    } = typeof queryOrOpts === 'string' ? { query: queryOrOpts } : queryOrOpts
+
+    // Tags are AND'ed together; we do not support OR'ing tags via parentheses.
+    const tags = [
+      ...(opts.tags ?? []),
+      opts.story ? `story_${opts.story}` : undefined,
+      opts.author ? `author_${opts.author}` : undefined
+    ].filter(Boolean)
+
+    return this.apiSearchKy
+      .get(sortBy === 'relevance' ? 'api/v1/search' : 'api/v1/search_by_date', {
+        searchParams: sanitizeSearchParams(
+          {
+            query,
+            tags,
+            numericFilters,
+            page,
+            hitsPerPage
+          },
+          { csv: true }
+        )
+      })
+      .json<hackernews.SearchResponse>()
+  }
+
+  @aiFunction({
+    name: 'hacker_news_get_top_stories',
+    description:
+      'Fetches / searches the top stories currently on the front page of HN. This is the same as `hacker_news_search`, but with `tags: ["front_page"]` set to filter only by the current front page stories.',
+    inputSchema: hackernews.searchOptionsSchema
+  })
+  async getSearchTopStories(queryOrOpts: string | hackernews.SearchOptions) {
+    const opts =
+      typeof queryOrOpts === 'string' ? { query: queryOrOpts } : queryOrOpts
+
+    return this.searchItems({
+      ...opts,
+      tags: ['front_page', ...(opts.tags ?? [])]
+    })
+  }
+
   async getItem(id: string | number) {
-    return this.ky.get(`v0/item/${id}.json`).json<hackernews.Item>()
+    return this.apiKy.get(`v0/item/${id}.json`).json<hackernews.Item>()
   }
 
   async getTopStories() {
-    return this.ky.get('v0/topstories.json').json<number[]>()
+    return this.apiKy.get('v0/topstories.json').json<number[]>()
   }
 
   async getNewStories() {
-    return this.ky.get('v0/newstories.json').json<number[]>()
+    return this.apiKy.get('v0/newstories.json').json<number[]>()
   }
 
   async getBestStories() {
-    return this.ky.get('v0/beststories.json').json<number[]>()
+    return this.apiKy.get('v0/beststories.json').json<number[]>()
   }
 }

legacy/packages/proxycurl/src/proxycurl-client.ts

@@ -2075,7 +2075,7 @@ export class ProxycurlClient extends AIFunctionsProvider {
     apiBaseUrl = getEnv('PROXYCURL_API_BASE_URL') ??
       'https://nubela.co/proxycurl',
     throttle = true,
-    timeoutMs = 30_000,
+    timeoutMs = 60_000,
     ky = defaultKy
   }: {
     apiKey?: string