Removed loads of @skip decorators from tests, as part of issue 47.

Tests now fail quite a lot. :)

kepi/bowler_pub/tests/mastodon/test_create.py

@@ -315,7 +315,6 @@ class Tests(Create_TestCase):
                 msg = 'status is in the same conversation',
                 )
 
-    @skip("Mentions are not yet implemented")
     @httpretty.activate
     def test_with_mentions(self):
 
@@ -373,7 +372,6 @@ class Tests(Create_TestCase):
     #   - emoji
     #   - polls
 
-    @skip("Need to set up a remote sender convincingly")
     @httpretty.activate
     def test_when_sender_is_followed_by_local_users(self):
 
@@ -492,7 +490,6 @@ class Tests(Create_TestCase):
     # Does it make a difference whether the message
     # was submitted to the shared inbox?
     # Check through masto's code.
-    @skip("Need to set up a remote sender convincingly")
     @httpretty.activate
     def test_when_sender_has_no_relevance_to_local_activity(self):
 

kepi/bowler_pub/tests/mastodon/test_like.py

@@ -1,11 +1,9 @@
 from kepi.trilby_api.tests import create_local_status, create_local_person
-from unittest import skip
 from kepi.bowler_pub.create import create
 from django.test import TestCase
 
 class TestLike(TestCase):
 
-    @skip("this assumes we can ask Person.has_favourited(); we can't yet")
     def test_like(self):
 
         sender = create_local_person('sender')

kepi/bowler_pub/tests/mastodon/test_update.py

@@ -16,7 +16,6 @@ logger = logging.getLogger(name='kepi')
 
 class TestUpdate(TestCase):
 
-    @skip("hardly written")
     def test_update_profile(self):
 
         sender = create_local_person()

kepi/bowler_pub/tests/test_headers.py

@@ -14,7 +14,6 @@ from unittest import skip
 
 MIME_TYPE = 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"'
 
-@skip("The header middleware is causing problems with testing at present")
 class TestHeaders(TestCase):
 
     def setUp(self):

kepi/bowler_pub/tests/test_read_from_outbox.py

@@ -3,7 +3,6 @@ from django.test import TestCase, Client
 from kepi.trilby_api.tests import create_local_person
 from kepi.trilby_api.models import Status
 import kepi.trilby_api.utils as trilby_utils
-from unittest import skip
 import httpretty
 import logging
 import json
@@ -106,7 +105,6 @@ class TestOutbox(TestCase):
                 [x['type'] for x in contents],
                 ['Create'])
 
-    @skip("still moving boosts over from the old architecture")
     def test_read_announce(self):
         # Announce, aka boost
         self._create_example_user([

kepi/bowler_pub/tests/test_views.py

@@ -1,7 +1,6 @@
 from django.test import TestCase, Client
 from . import *
 from kepi.trilby_api.tests import create_local_person, create_local_status
-from unittest import skip
 import logging
 import json
 
@@ -122,7 +121,6 @@ class Tests(TestCase):
             )
 
 
-@skip("Tombstones are not supported in this version")
 class TestTombstone(TestCase):
 
     def setUp(self):

kepi/sombrero_sendpub/tests/test_send.py

@@ -7,7 +7,6 @@
 import logging
 logger = logging.getLogger(name='kepi')
 
-from unittest import skip
 from django.test import TestCase
 from rest_framework.test import force_authenticate, APIClient
 from django.conf import settings
@@ -43,7 +42,6 @@ class TestSend(TestCase):
         self._client = APIClient()
         self._client.force_authenticate(self._alice.local_user)
 
-    @skip("TODO - mentions aren't yet implemented")
     @httpretty.activate
     def test_send_direct_message(self):
 
@@ -59,13 +57,11 @@ class TestSend(TestCase):
         self.assertEqual(result.status_code,
                 200)
 
-    @skip("TODO")
     def test_irrelevant(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("TODO - mentions aren't implemented")
     def test_mention(self):
-        pass
+        raise NotImplementedError()
 
     @httpretty.activate
     def test_follow(self):
@@ -80,10 +76,8 @@ class TestSend(TestCase):
         self.assertEqual(result.status_code,
                 200)
 
-    @skip("TODO")
     def test_accept_follow(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("TODO")
     def test_reject_follow(self):
-        pass
+        raise NotImplementedError()

kepi/trilby_api/tests/test_account.py

@@ -41,9 +41,8 @@ class TestAccountCredentials(TrilbyTestCase):
                         expected,
                         ))
 
-    @skip("I'll write this test later")
+    @skip("not sure how to write this test")
     def test_register(self):
-        # FIXME not sure how to implement this test!
         pass
 
     def test_update_credentials(self):
@@ -221,17 +220,14 @@ class TestAccountDetails(TrilbyTestCase):
                         o.username,
                         )
 
-    @skip("Not yet implemented")
     def test_account_in_lists(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_account_relationships(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_account_search(self):
-        pass
+        raise NotImplementedError()
 
 class TestAccountActions(TrilbyTestCase):
 
@@ -328,18 +324,14 @@ class TestAccountActions(TrilbyTestCase):
                     ).count(),
                 0)
 
-    @skip("Not yet implemented")
     def test_block(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_unblock(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_mute(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_unmute(self):
-        pass
+        raise NotImplementedError()

kepi/trilby_api/tests/test_instance.py

@@ -1,4 +1,3 @@
-from unittest import skip
 from rest_framework.test import APIClient, force_authenticate
 from kepi.trilby_api.views import *
 from kepi.trilby_api.tests import *
@@ -22,13 +21,11 @@ class TestInstance(TrilbyTestCase):
                 ]:
             self.assertIn(k, content)
 
-    @skip("Not yet implemented")
     def test_list_peers(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_list_weekly_activity(self):
-        pass
+        raise NotImplementedError()
 
     def test_get_emojis(self):
 

kepi/trilby_api/tests/test_notifications.py

@@ -1,4 +1,3 @@
-from unittest import skip
 from rest_framework.test import force_authenticate, APIClient, APIRequestFactory
 from kepi.trilby_api.views import *
 from kepi.trilby_api.tests import *
@@ -121,14 +120,11 @@ class TestNotifications(TrilbyTestCase):
                 content[0]['status'],
                 )
 
-    @skip("Not yet implemented")
     def test_get_single(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_clear(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_clear_single(self):
-        pass
+        raise NotImplementedError()

kepi/trilby_api/tests/test_person.py

@@ -6,7 +6,6 @@
 
 from kepi.trilby_api.tests import *
 from kepi.bowler_pub.tests import create_remote_person, mock_remote_object
-from unittest import skip
 from rest_framework.test import APIClient, force_authenticate
 import logging
 import httpretty

kepi/trilby_api/tests/test_search.py

@@ -1,4 +1,3 @@
-from unittest import skip
 from rest_framework.test import APIClient, force_authenticate
 from kepi.trilby_api.views import *
 from kepi.trilby_api.tests import *
@@ -12,8 +11,8 @@ class TestSearch(TrilbyTestCase):
 
     @skip("Not yet implemented")
     def test_v1(self):
-        pass
+        raise NotImplementedError()
 
     @skip("Not yet implemented")
     def test_v2(self):
-        pass
+        raise NotImplementedError()

kepi/trilby_api/tests/test_status.py

@@ -1,4 +1,3 @@
-from unittest import skip
 from rest_framework.test import APIClient, force_authenticate
 from kepi.trilby_api.views import *
 from kepi.trilby_api.tests import *
@@ -547,27 +546,21 @@ class TestStatus(TrilbyTestCase):
                 self._alice_status,
                 expect_result = 404)
 
-    @skip("Not yet implemented")
     def test_bookmark(self):
-        pass
+        raise NotImplementedError() 
 
-    @skip("Not yet implemented")
     def test_unbookmark(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_mute(self):
-        pass
+        raise NotImplementedError()
 
-    @skip("Not yet implemented")
     def test_unmute(self):
-        pass
+       raise NotImplementedError() 
 
-    @skip("Not yet implemented")
     def test_pin(self):
         self.fail("Test not yet implemented")
 
-    @skip("Not yet implemented")
     def test_unpin(self):
         self.fail("Test not yet implemented")
 

kepi/trilby_api/tests/test_timelines.py

@@ -7,7 +7,6 @@
 import logging
 logger = logging.getLogger(name='kepi')
 
-from unittest import skip
 from rest_framework.test import APIClient, force_authenticate
 from kepi.trilby_api.views import *
 from kepi.trilby_api.tests import *
@@ -128,16 +127,15 @@ class TestTimelines(TrilbyTestCase):
             as_user = self._alice,
             )
 
-    @skip("Hashtags not yet implemented")
     def test_hashtag(self):
+        raise NotImplementedError()
         pass
 
-    @skip("Not yet implemented")
     def test_account_statuses(self):
         # Special case: this isn't considered a timeline method
         # in the API, but it's similar enough that we test it here
+        raise NotImplementedError()
         pass
 
-    @skip("Lists not yet implemented")
     def test_list(self):
-        pass
+        raise NotImplementedError()