From a6d9aa96f7168467a5514004e4c922828f5d662c Mon Sep 17 00:00:00 2001 From: dgtlmoon Date: Thu, 12 Aug 2021 11:19:29 +0200 Subject: [PATCH] Updated Fetching pages with WebDriver (markdown) --- Fetching-pages-with-WebDriver.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Fetching-pages-with-WebDriver.md b/Fetching-pages-with-WebDriver.md index 3c36342..e59ee6a 100644 --- a/Fetching-pages-with-WebDriver.md +++ b/Fetching-pages-with-WebDriver.md @@ -22,4 +22,12 @@ The backend can be configured to fetch pages via Chrome using the built in [WebD Then visit `/settings` and `[Fetching]` tab and enable the WebDriver/Chrome option -The URL for the WebDriver interface is set with the `WEBDRIVER_URL` environment variable (`http://browser-chrome:4444/wd/hub` by default) \ No newline at end of file +The URL for the WebDriver interface is set with the `WEBDRIVER_URL` environment variable (`http://browser-chrome:4444/wd/hub` by default) + +#### There's a few things left todo + +* Make tests use the full docker stack with the chromedriver + relevant settings +* Lower the number of workers (make it configurable per backend?) 10 is too many (is it?), but this is totally fine for requests/plaintext +* Some kind of dom-wait-until-fully loaded or other +* Handle failures better (better feedback so we know if its from chromedriver, or from the website) +* Save last screenshot?