From a0665e1f1890c55139183221ae703fc76159256d Mon Sep 17 00:00:00 2001 From: dgtlmoon Date: Mon, 30 Oct 2023 16:08:31 +0100 Subject: [PATCH] Fetcher - experimental puppeteer fetch - dont rewrite the proxy protocol (fixes socks5 bug) --- changedetectionio/content_fetcher.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/changedetectionio/content_fetcher.py b/changedetectionio/content_fetcher.py index 2243567f..c17419af 100644 --- a/changedetectionio/content_fetcher.py +++ b/changedetectionio/content_fetcher.py @@ -333,9 +333,8 @@ class base_html_playwright(Fetcher): # Remove username/password if it exists in the URL or you will receive "ERR_NO_SUPPORTED_PROXIES" error # Actual authentication handled by Puppeteer/node o = urlparse(self.proxy.get('server')) - # Remove scheme, socks5:// doesnt always work and it will autodetect anyway - proxy_url = urllib.parse.quote(o._replace(netloc="{}:{}".format(o.hostname, o.port)).geturl().replace(f"{o.scheme}://", '', 1)) - browserless_function_url = f"{browserless_function_url}&--proxy-server={proxy_url}&dumpio=true" + proxy_url = urllib.parse.quote(o._replace(netloc="{}:{}".format(o.hostname, o.port)).geturl()) + browserless_function_url = f"{browserless_function_url}&--proxy-server={proxy_url}" try: amp = '&' if '?' in browserless_function_url else '?'