From f00eee5e8b2d2ab804d8dc55824787b5636fa6e1 Mon Sep 17 00:00:00 2001
From: Ruben Daniels <ruben@c9.io>
Date: Thu, 19 Feb 2015 17:06:48 +0000
Subject: [PATCH] Some docs related changes to pane

---
 plugins/c9.core/ext.js             | 12 ++++++------
 plugins/c9.ide.console/console.js  |  4 ++--
 plugins/c9.ide.editors/document.js |  2 +-
 plugins/c9.ide.editors/pane.js     | 27 +++++++++++++--------------
 4 files changed, 22 insertions(+), 23 deletions(-)

diff --git a/plugins/c9.core/ext.js b/plugins/c9.core/ext.js
index 0dcead7a..fe7d79c9 100644
--- a/plugins/c9.core/ext.js
+++ b/plugins/c9.core/ext.js
@@ -124,12 +124,6 @@ define(function(require, exports, module) {
             return usedBy
         }
         
-        function loadRemotePlugin(id, options, callback) {
-            vfs.extend(id, options, function(err, meta) {
-                callback(err, meta && meta.api);
-            });
-        }
-        
         function unloadAllPlugins(exclude) {
             if (lut.settings)
                 lut.settings.unload(null, true);
@@ -160,6 +154,12 @@ define(function(require, exports, module) {
             }
         }
         
+        function loadRemotePlugin(id, options, callback) {
+            vfs.extend(id, options, function(err, meta) {
+                callback(err, meta && meta.api);
+            });
+        }
+        
         function fetchRemoteApi(id, callback) {
             vfs.use(id, {}, function(err, meta) {
                 callback(err, meta && meta.api);
diff --git a/plugins/c9.ide.console/console.js b/plugins/c9.ide.console/console.js
index c3d01435..8ee3b85f 100644
--- a/plugins/c9.ide.console/console.js
+++ b/plugins/c9.ide.console/console.js
@@ -185,7 +185,7 @@ define(function(require, module, exports) {
 
             tabs.on("paneCreate", function(e) {
                 if (hidden && container && ui.isChildOf(container, e.pane.aml)) {
-                    e.pane.visible = false;
+                    e.pane._visible = false;
                 }
             });
 
@@ -297,7 +297,7 @@ define(function(require, module, exports) {
             maxHeight = window.innerHeight - 70;
             
             getPanes().forEach(function(pane) {
-                pane.visible = !shouldHide;
+                pane._visible = !shouldHide;
             });
             
             if (!shouldHide && !tabs.focussedTab) {
diff --git a/plugins/c9.ide.editors/document.js b/plugins/c9.ide.editors/document.js
index 5326b831..596abdf0 100644
--- a/plugins/c9.ide.editors/document.js
+++ b/plugins/c9.ide.editors/document.js
@@ -362,7 +362,7 @@ define(function(require, module, exports) {
                 },
                 /**
                  * Sets or retrieves the serialized value of this document.
-                 * Setting this document will not change the undo stack. Set
+                 * Setting this property will not change the undo stack. Set
                  * this property only to initialize the document or to reset
                  * the value of this document. Requesting the value of this
                  * document will cause it to serialize it's full state.
diff --git a/plugins/c9.ide.editors/pane.js b/plugins/c9.ide.editors/pane.js
index 359bcc24..851de469 100644
--- a/plugins/c9.ide.editors/pane.js
+++ b/plugins/c9.ide.editors/pane.js
@@ -657,20 +657,18 @@ define(function(require, module, exports) {
                  * @readonly
                  */
                 get group(){
-                    function getGroup(amlPane) {
-                        var pNode = amlPane.parentNode;
+                    var pNode = amlPane.parentNode;
+                    
+                    if (pNode.localName.indexOf("splitbox") == -1)
+                        return false;
                         
-                        if (pNode.localName.indexOf("splitbox") == -1)
-                            return false;
-                            
-                        var result = pNode.childNodes.map(function(aml) {
-                            return aml.cloud9pane;
-                        });
-                        // result.__defineGetter__("group", function(){
-                        //     return getGroup(pNode)
-                        // });
-                        return result;
-                    }
+                    var result = [];
+                    pNode.childNodes.forEach(function(aml) {
+                        if (aml.cloud9pane)
+                            result.push(aml.cloud9pane);
+                    });
+                    
+                    return result;
                 },
                 
                 /**
@@ -703,7 +701,8 @@ define(function(require, module, exports) {
                  * @readonly
                  */
                 get visible(){ return visible; },
-                set visible(v){ visible = v; },
+                set visible(v){ amlPane.setProperty("visible", v); visible = v; },
+                set _visible(v){ visible = v; },
                 
                 /**
                  * Retrieves the meta object for this panel