From d568e250e48b1a5d919e8a8ee3eec64a55d71b3a Mon Sep 17 00:00:00 2001 From: Ruben Daniels Date: Thu, 12 Nov 2015 19:56:35 +0000 Subject: [PATCH] Fixes +9934. Show alert when using the experimental panel --- plugins/c9.ide.preferences/experimental.js | 15 +++++++++++---- plugins/c9.ide.ui/forms.js | 7 +++++-- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/plugins/c9.ide.preferences/experimental.js b/plugins/c9.ide.preferences/experimental.js index d7f84b52..621400b4 100644 --- a/plugins/c9.ide.preferences/experimental.js +++ b/plugins/c9.ide.preferences/experimental.js @@ -1,17 +1,16 @@ define(function(require, exports, module) { main.consumes = [ - "PreferencePanel", "ui", "dialog.confirm", "settings", - "preferences", "c9" + "PreferencePanel", "ui", "dialog.alert", "settings", "c9" ]; main.provides = ["preferences.experimental"]; return main; function main(options, imports, register) { var PreferencePanel = imports.PreferencePanel; - var prefs = imports.preferences; var settings = imports.settings; var ui = imports.ui; var c9 = imports.c9; + var alert = imports["dialog.alert"].show; /***** Initialization *****/ @@ -23,7 +22,7 @@ define(function(require, exports, module) { var emit = plugin.getEmitter(); emit.setMaxListeners(1000); - var intro; + var intro, hasAlerted; var loaded = false; function load() { @@ -71,6 +70,14 @@ define(function(require, exports, module) { } current.type = "checkbox"; current.setting = "state/experiments/@" + uniqueId; + current.onchange = function(e){ + if (!hasAlerted) { + alert("Refresh Needed", + "Please Refresh Cloud9 To Activate This Change", + "To see the effect of this change, please refresh Cloud9."); + hasAlerted = true; + } + } if (!found[name]) plugin.add(obj, plugin); diff --git a/plugins/c9.ide.ui/forms.js b/plugins/c9.ide.ui/forms.js index 400e7148..959e0d45 100644 --- a/plugins/c9.ide.ui/forms.js +++ b/plugins/c9.ide.ui/forms.js @@ -190,8 +190,11 @@ define(function(require, exports, module) { ? createBind(options.path) : (options.defaultValue || ""), values: options.values, - skin: "cboffline" - // width: "55" + skin: "cboffline", + onafterchange: function(e) { + if (options.onchange) + options.onchange({ value: e.value }); + } }) ]; break;