Merge pull request +6286 from c9/sdk

Sdk

plugins/c9.core/ext.js

@@ -124,12 +124,6 @@ define(function(require, exports, module) {
             return usedBy
         }
         
-        function loadRemotePlugin(id, options, callback) {
-            vfs.extend(id, options, function(err, meta) {
-                callback(err, meta && meta.api);
-            });
-        }
-        
         function unloadAllPlugins(exclude) {
             if (lut.settings)
                 lut.settings.unload(null, true);
@@ -160,6 +154,12 @@ define(function(require, exports, module) {
             }
         }
         
+        function loadRemotePlugin(id, options, callback) {
+            vfs.extend(id, options, function(err, meta) {
+                callback(err, meta && meta.api);
+            });
+        }
+        
         function fetchRemoteApi(id, callback) {
             vfs.use(id, {}, function(err, meta) {
                 callback(err, meta && meta.api);

plugins/c9.ide.ace/ace.js

@@ -2115,7 +2115,7 @@ define(function(require, exports, module) {
                         hideProgress();
                     }
                     
-                    if (e.state)
+                    if (e.state) // There is nowhere where e.state is set. Dead code?
                         setState(doc, e.state);
                         
                     if (currentDocument === doc)

plugins/c9.ide.console/console.js

@@ -185,7 +185,7 @@ define(function(require, module, exports) {
 
             tabs.on("paneCreate", function(e) {
                 if (hidden && container && ui.isChildOf(container, e.pane.aml)) {
-                    e.pane.visible = false;
+                    e.pane._visible = false;
                 }
             });
 
@@ -297,7 +297,7 @@ define(function(require, module, exports) {
             maxHeight = window.innerHeight - 70;
             
             getPanes().forEach(function(pane) {
-                pane.visible = !shouldHide;
+                pane._visible = !shouldHide;
             });
             
             if (!shouldHide && !tabs.focussedTab) {

plugins/c9.ide.editors/document.js

@@ -340,7 +340,7 @@ define(function(require, module, exports) {
                 set ready(v) {
                     if (ready) throw new Error("Permission Denied");
                     ready = true;
-                    emit.sticky("ready");
+                    emit.sticky("ready", { doc: plugin });
                 },
                 /**
                  * The tooltip displayed when hovering over the tab button
@@ -362,14 +362,14 @@ define(function(require, module, exports) {
                 },
                 /**
                  * Sets or retrieves the serialized value of this document.
-                 * Setting this document will not change the undo stack. Set
+                 * Setting this property will not change the undo stack. Set
                  * this property only to initialize the document or to reset
                  * the value of this document. Requesting the value of this
                  * document will cause it to serialize it's full state.
                  * @property {String} value
                  */
                 get value(){
-                    var calculated = emit("getValue", {value: value});
+                    var calculated = emit("getValue", { value: recentValue || value });
                     if (typeof calculated != "string")
                         calculated = value;
                     

plugins/c9.ide.editors/editor.js

@@ -205,7 +205,8 @@ define(function(require, module, exports) {
             
             /***** Register and define API *****/
             
-            plugin.freezePublicAPI.baseclass();
+            // This is a base class
+            plugin.baseclass();
             
             /**
              * Editor base class for Cloud9 Editors. Each file that is opened

plugins/c9.ide.editors/pane.js

@@ -657,20 +657,18 @@ define(function(require, module, exports) {
                  * @readonly
                  */
                 get group(){
-                    function getGroup(amlPane) {
                     var pNode = amlPane.parentNode;
                     
                     if (pNode.localName.indexOf("splitbox") == -1)
                         return false;
                         
-                        var result = pNode.childNodes.map(function(aml) {
-                            return aml.cloud9pane;
+                    var result = [];
+                    pNode.childNodes.forEach(function(aml) {
+                        if (aml.cloud9pane)
+                            result.push(aml.cloud9pane);
                     });
-                        // result.__defineGetter__("group", function(){
-                        //     return getGroup(pNode)
-                        // });
+                    
                     return result;
-                    }
                 },
                 
                 /**
@@ -703,7 +701,8 @@ define(function(require, module, exports) {
                  * @readonly
                  */
                 get visible(){ return visible; },
-                set visible(v){ visible = v; },
+                set visible(v){ amlPane.setProperty("visible", v); visible = v; },
+                set _visible(v){ visible = v; },
                 
                 /**
                  * Retrieves the meta object for this panel

plugins/c9.ide.editors/undomanager.js

@@ -205,8 +205,8 @@ define(function(require, module, exports) {
              *     }
              *     
              *     var undoManager = new UndoManager();
-             *     undoManager.add(new Item("a", 0)); // data = ["a"]
-             *     undoManager.add(new Item("b", 1)); // data = ["a", "b"]
+             *     undoManager.add(new Item("a").redo()); // data = ["a"]
+             *     undoManager.add(new Item("b").redo()); // data = ["a", "b"]
              * 
              *     undoManager.undo(); // data = ["a"];
              *     undoManager.undo(); // data = [];