Merge pull request +9523 from c9/issue-9491-fix-errors

Issue 9491 fix errors

configs/standalone.js

@@ -125,6 +125,7 @@ module.exports = function(config, optimist) {
         },
         {
             packagePath: "./c9.error/error_handler",
+            mode: config.mode,
             scope: "standalone",
             hostname: config.hostname
         },

plugins/c9.error/error_handler.js

@@ -4,7 +4,7 @@ var errors = require("http-error");
 
 plugin.consumes = [
     "connect",
-    "connect.static", 
+    "connect.static",
     "connect.render",
     "connect.render.ejs"
 ];
@@ -14,8 +14,13 @@ plugin.provides = [
 
 module.exports = plugin;
 
-var errorPages = { 404: 1, 401: 1, 500: 1, 503: 1};
- 
+var errorPages = {
+    404: 1,
+    401: 1,
+    500: 1,
+    503: 1
+};
+
 var statusCodes = {
     400: "Bad Request",
     401: "Unauthorized",
@@ -64,14 +69,18 @@ var statusCodes = {
 };
 
 var NICE_USER_ERROR_MSG = "Something went wrong. Please retry in a few minutes and contact support if it continues to occur";
- 
+
 function plugin(options, imports, register) {
     var connect = imports.connect;
     var showStackTrace = false;
 
     var frontdoor = require("frontdoor");
     var statics = imports["connect.static"];
-    
+
+    function isDev(mode) {
+        return /^(onlinedev|devel)$/.test(mode);
+    }
+
     // serve index.html
     statics.addStatics([{
         path: __dirname + "/www",
@@ -80,61 +89,64 @@ function plugin(options, imports, register) {
 
     // make sure res.json is available
     connect.useStart(frontdoor.middleware.jsonWriter());
-    
+
+    function sanitizeErrorCode(code) {
+        code = parseInt(code, 10);
+
+        if (isNaN(code)) return 500;
+        if (code < 400) return 500;
+        
+        return code;
+    }
+
+
     connect.useError(function(err, req, res, next) {
         if (typeof err == "string")
             err = new errors.InternalServerError(err);
-            
-        var statusCode = parseInt(err.code || err.status || res.statusCode, 10) || 500;
 
-        if (statusCode < 400)
-            statusCode = 500;
+        var statusCode = sanitizeErrorCode(err.code || err.status || res.statusCode);
+        var stack;
 
-        if (statusCode < 100)
-            statusCode = 500;
+        if (isDev(options.mode))
+            stack = err.stack || err.message || err.toString();
 
-        var stack = err.stack || err.message || err.toString();
-        console.error(stack);
         var accept = req.headers.accept || '';
-        // html
-        if (~accept.indexOf('html')) {
-            stack = stack.split('\n').slice(1);
-            
-            var path = errorPages[statusCode]
-                ? __dirname + "/views/error-" + statusCode + ".html.ejs"
-                : __dirname + "/views/error.html.ejs";
 
-            res.setHeader('Content-Type', 'text/html; charset=utf-8');
-            res.render(path, {
-                title: statusCodes[statusCode] || NICE_USER_ERROR_MSG,
-                scope: options.scope || "",
-                showStackTrace: showStackTrace,
-                stack: stack,
-                statusCode: statusCode,
-                error: err.toString()
-            }, next);
-        // json
-        } else if (~accept.indexOf('json')) {
+        if (/json/.test(accept)) {
             var error = {
+                code: statusCode,
                 message: err.message,
                 hostname: options.hostname,
-                scope: options.scope
+                scope: options.scope,
+                stack: stack,
             };
 
-            for (var prop in err) error[prop] = err[prop];
             try {
                 JSON.stringify(error);
-            } catch (e) {
+            }
+            catch (e) {
                 console.error("Cannot send error as JSON: ", error);
                 error.message = NICE_USER_ERROR_MSG;
                 error.scope = null;
             }
-            res.json({ error: error }, null, statusCode);
-        // plain text
-        } else {
-            res.writeHead(statusCode, { 'Content-Type': 'text/plain' });
-            res.end(stack);
+
+            return res.json({
+                error: error
+            }, null, statusCode);
         }
+
+        var path = errorPages[statusCode] ? __dirname + "/views/error-" + statusCode + ".html.ejs" : __dirname + "/views/error.html.ejs";
+
+        res.setHeader('Content-Type', 'text/html; charset=utf-8');
+        
+        res.render(path, {
+            title: statusCodes[statusCode] || NICE_USER_ERROR_MSG,
+            scope: options.scope || "",
+            showStackTrace: showStackTrace,
+            stack: stack.split('\n').slice(1),
+            statusCode: statusCode,
+            error: err.toString()
+        }, next);
     });
 
     register(null, {