From bbb4927d89680da065b5f963d294ae545495c20d Mon Sep 17 00:00:00 2001
From: Tim Robinson <tim@c9.io>
Date: Thu, 24 Sep 2015 09:10:17 +0000
Subject: [PATCH] Better logging of error dialogs so we can find them in raygun

---
 plugins/c9.ide.dialog.common/error.js | 32 +++++++++++++++------------
 1 file changed, 18 insertions(+), 14 deletions(-)

diff --git a/plugins/c9.ide.dialog.common/error.js b/plugins/c9.ide.dialog.common/error.js
index 7e25383e..730e4c15 100644
--- a/plugins/c9.ide.dialog.common/error.js
+++ b/plugins/c9.ide.dialog.common/error.js
@@ -84,6 +84,22 @@ define(function(require, exports, module) {
             
             return b1.left + b1.width + ((b2.left - b1.left - b1.width)/2);
         }
+        
+        function getMessageString(message) {
+            var messageString;
+            if (typeof message == "string") {
+                messageString = apf.escapeXML(message);
+            }
+            else {
+                if (message.message)
+                    messageString = apf.escapeXML(message.message);
+                else if (message.html)
+                    messageString = message.html;
+                else
+                    messageString = "Error: " + message.toString();
+            }
+            return messageString
+        }
 
         function show(message, timeout) {
             // Error message container
@@ -105,23 +121,11 @@ define(function(require, exports, module) {
                     return console.error("empty error message", message);
                 }
                 
-                console.error("Error:", 
-                    message.stack || message.html || message.message || message);
+                console.error("Error dialog shown: ", getMessageString(message));
             }
             
             hide(function() {
-                var messageString;
-                if (typeof message == "string") {
-                    messageString = apf.escapeXML(message);
-                }
-                else {
-                    if (message.message)
-                        messageString = apf.escapeXML(message.message);
-                    else if (message.html)
-                        messageString = message.html;
-                    else
-                        messageString = "Error: " + message.toString();
-                }
+                var messageString = getMessageString(message);
                 error.innerHTML = "<div><u class='close'></u>" 
                     + messageString + "</div>";