revert isNaN check, remove unused function

plugins/c9.ide.ui/lib_apf.js

@@ -1811,25 +1811,6 @@ defineProp(Array.prototype, "pushUnique", function(){
     return this;
 });
 
-/*
- * @todo: Ruben: could you please comment on this function? Seems to serve a very
- * specific purpose...
- *
- * I also could not find an occurrence in our codebase.
- */
-defineProp(Array.prototype, "search", function(){
-    for (var i = 0, length = arguments.length; i < length; i++) {
-        if (!Array.isArray(this[i]))
-            continue;
-        for (var j = 0; j < length; j++) {
-            if (this[i][j] != arguments[j])
-                break;
-            else if (j == (length - 1))
-                return this[i];
-        }
-    }
-});
-
 /*
  * Iterate through each value of an array instance from left to right (front to
  * back) and execute a callback Function for each value.
@@ -3725,8 +3706,7 @@ apf.setNodeValue = function(xmlNode, nodeValue) {
     }
     else {
         var oldValue = xmlNode.nodeValue;
-        xmlNode.nodeValue = nodeValue === undefined || nodeValue === null ||
+        xmlNode.nodeValue = nodeValue == null ? "" : String(nodeValue);
-            isNaN(nodeValue) ? "" : String(nodeValue);
 
         //AML support - getters/setters would be awesome
         if (xmlNode.$triggerUpdate)