From 94c568a5328244c53d5c37b003b9e84dac46a46d Mon Sep 17 00:00:00 2001
From: Dana <dana@c9.io>
Date: Mon, 23 Nov 2015 09:43:34 +0000
Subject: [PATCH] Fixes regex and tests

---
 node_modules/c9/has-internal-test-name.js     |  2 +-
 .../c9/has-internal-test-name_test.js         | 15 ++++++---------
 node_modules/c9/skip-analytics.js             |  1 +
 node_modules/c9/skip-analytics_test.js        | 19 +++++++++++++++++++
 4 files changed, 27 insertions(+), 10 deletions(-)

diff --git a/node_modules/c9/has-internal-test-name.js b/node_modules/c9/has-internal-test-name.js
index 72c7413b..9b99f096 100644
--- a/node_modules/c9/has-internal-test-name.js
+++ b/node_modules/c9/has-internal-test-name.js
@@ -8,7 +8,7 @@ define(function(require, exports, module) {
     "use strict";
 
     var internalTestNames = ["c9test", "c9 test"];
-   var regex = new RegExp(".*(" + internalTestNames.join("|") + ").*", "g");
+    var regex = new RegExp("^(" + internalTestNames.join("|") + ")+");
 
     function hasInternalTestName(name) {
         if (!name) return false;
diff --git a/node_modules/c9/has-internal-test-name_test.js b/node_modules/c9/has-internal-test-name_test.js
index 3909cf93..9e5dff4c 100644
--- a/node_modules/c9/has-internal-test-name_test.js
+++ b/node_modules/c9/has-internal-test-name_test.js
@@ -15,27 +15,24 @@ describe("has-internal-test-name", function() {
     });
     
     it("returns true when name contains c9test", function() {
-        var name = "c9testjkdfkfd";
+        var name = "c9testregnjkdfkfd";
         assert.equal(true, hasInternalTestName(name), "should return true when name contains c9test");
         
-        name = "c9test jjkdfhfkjfdh";
+        name = "c9test01";
         assert.equal(true, hasInternalTestName(name), "should return true when name contains c9test");
         
-        name = " c9testjhrrj";
-        assert.equal(true, hasInternalTestName(name), "should return true when name contains c9test");
-        
-        name = " c9testjhrrj ffjh";
+        name = "c9testjhrrj ffjh";
         assert.equal(true, hasInternalTestName(name), "should return true when name contains c9test");
     });
-    
+
     it("returns true when name contains c9 test", function() {
         var name = "c9 test dkjfdgjhfgdfk";
         assert.equal(true, hasInternalTestName(name), "should return true when name contains c9 test");
         
-        name = "c9 testdkjfdgjhfgdfk";
+        name = "c9 test07";
         assert.equal(true, hasInternalTestName(name), "should return true when name contains c9 test");
         
-        name = " c9 test dkjfdgjhfgdfk ";
+        name = "c9 testdkjfdgjhfgdfk";
         assert.equal(true, hasInternalTestName(name), "should return true when name contains c9 test");
     });
     
diff --git a/node_modules/c9/skip-analytics.js b/node_modules/c9/skip-analytics.js
index 7133131c..108f8a76 100644
--- a/node_modules/c9/skip-analytics.js
+++ b/node_modules/c9/skip-analytics.js
@@ -13,6 +13,7 @@ define(function(require, exports, module) {
      function skipAnalytics(user) {
         if (!user) return true;
         if (user.id === -1) return true;   
+
         if (hasInternalTestName(user.name)) return true;
         if (hasInternalDomain(user.email)) return true; 
         return false;
diff --git a/node_modules/c9/skip-analytics_test.js b/node_modules/c9/skip-analytics_test.js
index 300251b0..bfaf1215 100644
--- a/node_modules/c9/skip-analytics_test.js
+++ b/node_modules/c9/skip-analytics_test.js
@@ -22,6 +22,25 @@ describe("skip-analytics", function() {
         assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user id is -1");
     });
     
+     
+    it("returns false when user does not have an internal test name and no email", function() {
+        var user = {
+            id: faker.random.uuid(),
+            name: faker.name.firstName()
+        };
+        
+        assert.equal(false, skipAnalytics(user), "skipAnalytics should return false when user does not have an internal test name and no email");
+    });
+    
+    it("returns true when user has an internal test name and no email", function() {
+        var user = {
+            id: faker.random.uuid(),
+            name: "c9test07"
+        };
+        
+        assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user has an internal test name and no email");
+    });
+    
     it("returns false when user has no email", function() {
         var user = {
             id: faker.random.uuid()