From 3c81d38df600fac8245f6239bb1aea01cb261b9c Mon Sep 17 00:00:00 2001 From: nightwing Date: Thu, 27 Aug 2015 23:21:57 +0400 Subject: [PATCH 1/2] do not automatically show collab button --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 96a5c86e..381a6b78 100644 --- a/package.json +++ b/package.json @@ -66,7 +66,7 @@ "c9.ide.language.javascript.tern": "#9bf164ec27", "c9.ide.language.javascript.infer": "#8478e3c702", "c9.ide.language.jsonalyzer": "#e0d94eda4f", - "c9.ide.collab": "#c74666f592", + "c9.ide.collab": "#fd08d9a123", "c9.ide.local": "#a9703b630c", "c9.ide.find": "#e073bf251a", "c9.ide.find.infiles": "#c132ad243c", From 2e46a79bfe84635e0b79704b654a5434218849a9 Mon Sep 17 00:00:00 2001 From: nightwing Date: Fri, 28 Aug 2015 14:34:13 +0400 Subject: [PATCH 2/2] only include plugins from package.json in built extension --- plugins/c9.cli.publish/publish.js | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/plugins/c9.cli.publish/publish.js b/plugins/c9.cli.publish/publish.js index 2a4504f6..9d11b867 100644 --- a/plugins/c9.cli.publish/publish.js +++ b/plugins/c9.cli.publish/publish.js @@ -282,6 +282,17 @@ define(function(require, exports, module) { // Validate plugins var plugins = {}; + + var warned, failed; + Object.keys(json.plugins || {}).forEach(function(name){ + var filename = name + ".js"; + if (!fs.existsSync(join(cwd, name + "_test.js"))) { + console.warn("ERROR: Plugin '" + name + "' has no test associated with it. There must be a file called '" + name + "_test.js' containing tests."); + warned = true; + } + plugins[filename] = json.plugins[name]; + }); + fs.readdirSync(cwd).forEach(function(filename) { if (/(__\w*__|_test)\.js$/.test(filename) || !/\.js$/.test(filename)) return; try { @@ -293,18 +304,8 @@ define(function(require, exports, module) { if (!/\(options,\s*imports,\s*register\)/.test(val)) return; if (!/consumes\s*=/.test(val)) return; if (!/provides\s*=/.test(val)) return; - plugins[filename] = {}; - }); - - var warned, failed; - Object.keys(plugins).forEach(function(name){ - if (!json.plugins[name.replace(/\.js$/, "")]) { - console.warn("WARNING: Plugin '" + name + "' is not listed in package.json."); - warned = true; - } - else if (!fs.existsSync(join(cwd, name.replace(/\.js$/, "_test.js")))) { - console.warn("ERROR: Plugin '" + name + "' has no test associated with it. There must be a file called '" + name.replace(/\.js$/, "") + "_test.js' containing tests."); - warned = true; + if (!plugins[filename]) { + console.warn("WARNING: Plugin '" + filename + "' is not listed in package.json."); } });