From 1eba1b1b205d2e44ce04ffb1d8e82a70cd73a5d8 Mon Sep 17 00:00:00 2001 From: Tim Robinson Date: Mon, 27 Jun 2016 12:58:04 +0000 Subject: [PATCH 1/2] Adding a onPingComplete callback without needing to include metrics_core module --- plugins/c9.ide.metrics/metrics.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/plugins/c9.ide.metrics/metrics.js b/plugins/c9.ide.metrics/metrics.js index 83f6f527..5123f14b 100644 --- a/plugins/c9.ide.metrics/metrics.js +++ b/plugins/c9.ide.metrics/metrics.js @@ -120,6 +120,11 @@ define(function(require, exports, module) { * @return {Object} */ getLastPing: apiFunction.bind(null, "getLastPing"), + + /** + * Add a hook for ping.complete + */ + onPingComplete: apiFunction.bind(null, "onPingComplete"), }); register(null, { metrics: plugin }); From 50dfe00205f119716e6beaf234152fc9c2afa857 Mon Sep 17 00:00:00 2001 From: Tim Robinson Date: Mon, 27 Jun 2016 12:59:40 +0000 Subject: [PATCH 2/2] Adding mock function for tests --- plugins/c9.vfs.standalone/www/test.js | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/c9.vfs.standalone/www/test.js b/plugins/c9.vfs.standalone/www/test.js index 1fd0abcb..535bf746 100644 --- a/plugins/c9.vfs.standalone/www/test.js +++ b/plugins/c9.vfs.standalone/www/test.js @@ -446,6 +446,7 @@ require([ "metrics": { getLastPing: function() { throw Error("Not implemented"); }, getLastest: function() { throw Error("Not implemented"); }, + onPingComplete: function() { throw Error("Not implemented"); }, log: function() {}, increment: function() {} },