From 91c5898ccc1210c946fce955d0da17b303e54349 Mon Sep 17 00:00:00 2001 From: Matthijs van Henten Date: Tue, 8 Mar 2016 11:30:56 +0000 Subject: [PATCH 1/2] move the null check up --- node_modules/c9/skip-analytics.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/node_modules/c9/skip-analytics.js b/node_modules/c9/skip-analytics.js index 4325d3f8..c39a3e8b 100644 --- a/node_modules/c9/skip-analytics.js +++ b/node_modules/c9/skip-analytics.js @@ -1,7 +1,7 @@ -if (typeof define === "undefined") { - var define = function(fn) { - fn(require, exports, module); - }; +if (typeof define === "undefined") { + var define = function(fn) { + fn(require, exports, module); + }; } define(function(require, exports, module) { From 1cef467279bde497de3694958b7cd3da60a82075 Mon Sep 17 00:00:00 2001 From: Matthijs van Henten Date: Tue, 8 Mar 2016 12:42:12 +0000 Subject: [PATCH 2/2] fix the order ; --- node_modules/c9/skip-analytics.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/node_modules/c9/skip-analytics.js b/node_modules/c9/skip-analytics.js index c39a3e8b..30be5d51 100644 --- a/node_modules/c9/skip-analytics.js +++ b/node_modules/c9/skip-analytics.js @@ -12,13 +12,13 @@ define(function(require, exports, module) { function skipAnalytics(userId, name, email, allowUnauthorized) { + if (!userId) return true; // users without an id should never reach the Segment library + if (typeof userId == "object") { var user = userId; return skipAnalytics(user.id, user.name || user.username, user.email, name); // make it backwards compatible for the client } - - if (!userId) return true; // users without an id should never reach the Segment library - + if (!allowUnauthorized && userId === -1) return true; if (hasInternalTestName(name)) return true;