Fixes +10723 and adds extra tests

node_modules/c9/skip-analytics.js

@@ -12,7 +12,7 @@ define(function(require, exports, module) {
 
      function skipAnalytics(user) {
         if (!user) return true;
-        if (user.id === -1) return true;   
+        if (user.id === -1 || user.uid === -1) return true;   
 
         if (hasInternalTestName(user)) return true;
         if (hasInternalDomain(user.email)) return true; 

node_modules/c9/skip-analytics_test.js

@@ -10,63 +10,71 @@ describe("skip-analytics", function() {
 
     it("returns true when user undefined", function() {
         var user;
-        
+
         assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user undefined");
     });
-    
+
     it("returns true when user id is -1", function() {
         var user = {
             id: -1
         };
-        
+
         assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user id is -1");
     });
-    
-     
+
+    it("returns true when user uid is -1", function() {
+        var user = {
+            uid: -1
+        };
+
+        assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user uid is -1");
+    });
+
+
     it("returns false when user does not have an internal test name and no email", function() {
         var user = {
             id: faker.random.uuid(),
             name: faker.name.firstName()
         };
-        
+
         assert.equal(false, skipAnalytics(user), "skipAnalytics should return false when user does not have an internal test name and no email");
     });
-    
+
     it("returns true when user has an internal test name and no email", function() {
         var user = {
             id: faker.random.uuid(),
             name: "c9test07"
         };
-        
+
         assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user has an internal test name and no email");
     });
-    
+
     it("returns false when user has no email", function() {
         var user = {
             id: faker.random.uuid()
         };
-        
+
         assert.equal(false, skipAnalytics(user), "skipAnalytics should return false when user has no email");
     });
-    
+
     it("returns true when user has internal email", function() {
         var user = {
             id: faker.random.uuid(),
             email: "test@c9.io"
         };
-        
+
         assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user has internal email");
-        
+
         user.email = "test@cloud9beta.com";
         assert.equal(true, skipAnalytics(user), "skipAnalytics should return true when user has internal beta email");
     });
-    
-     it("returns false when user is authorized and does not have intermal email", function() {
+
+    it("returns false when user is authorized and does not have intermal email", function() {
         var user = {
             id: faker.random.uuid(),
             email: faker.internet.email()
         };
-        
+
         assert.equal(false, skipAnalytics(user), "skipAnalytics should return false when user is authorized and does not have internal email");
     });
 });