From 16e943d78a3f6b420a5d11c5453504e8c0483040 Mon Sep 17 00:00:00 2001 From: nightwing Date: Mon, 27 Mar 2017 23:21:56 +0400 Subject: [PATCH 1/3] fix files getting opener icon occasionally --- plugins/c9.fs/fs.cache.xml.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/c9.fs/fs.cache.xml.js b/plugins/c9.fs/fs.cache.xml.js index ab9af453..13c2ccd3 100644 --- a/plugins/c9.fs/fs.cache.xml.js +++ b/plugins/c9.fs/fs.cache.xml.js @@ -258,7 +258,7 @@ define(function(require, exports, module) { }; e.confirm = function () { if (node.status === "predicted") - node.status = "pending"; + node.status = isFolder ? "pending" : "loaded"; }; node.status = "predicted"; } From ab69b6db5022d2e6be1f5225e07c413d255879da Mon Sep 17 00:00:00 2001 From: nightwing Date: Tue, 28 Mar 2017 21:39:24 +0000 Subject: [PATCH 2/3] do not open console if find results tab is not there --- plugins/c9.ide.find.infiles/findinfiles.js | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/plugins/c9.ide.find.infiles/findinfiles.js b/plugins/c9.ide.find.infiles/findinfiles.js index 90ce4e44..6b70a167 100644 --- a/plugins/c9.ide.find.infiles/findinfiles.js +++ b/plugins/c9.ide.find.infiles/findinfiles.js @@ -520,16 +520,10 @@ define(function(require, exports, module) { if (cb && typeof cb != "function") cb = undefined; // called from libsearch options = options || getOptions(); - - // Open Console - if (chkSFConsole.checked) - c9console.show(); makeSearchResultsPanel(function(err, tab) { - if (err) { - c9console.error("Error creating search panel"); - return; - } + if (err) + return console.error("Error creating search panel"); var session = tab.document.getSession(); var acesession = session.session; @@ -822,13 +816,12 @@ define(function(require, exports, module) { return /.*/.exec(str)[0]; } - var searchPanel = {}; function makeSearchResultsPanel(callback) { - var tab = searchPanel[chkSFConsole.checked]; + var tab = tabs.findTab("/.c9/searchresults"); - if (!tab || !tab.loaded) { + if (!tab) { var root = chkSFConsole.checked ? c9console : tabs; - searchPanel[chkSFConsole.checked] = root.open({ + root.open({ path: "/.c9/searchresults", // This allows the tab to be saved focus: true, document: { From 10003c59956e8029d5fb34d2154e2eae142f92fa Mon Sep 17 00:00:00 2001 From: nightwing Date: Tue, 28 Mar 2017 22:05:13 +0000 Subject: [PATCH 3/3] ctrl-z in searchresults should go to results of the previous search --- plugins/c9.ide.find.infiles/findinfiles.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/plugins/c9.ide.find.infiles/findinfiles.js b/plugins/c9.ide.find.infiles/findinfiles.js index 6b70a167..8556ceb3 100644 --- a/plugins/c9.ide.find.infiles/findinfiles.js +++ b/plugins/c9.ide.find.infiles/findinfiles.js @@ -529,6 +529,7 @@ define(function(require, exports, module) { var acesession = session.session; var doc = acesession.getDocument(); + acesession.mergeUndoDeltas = false; if (settings.getBool("user/findinfiles/@clear")) doc.setValue(""); @@ -598,6 +599,7 @@ define(function(require, exports, module) { } find.findFiles(options, function(err, stream, process) { if (err) { + acesession.mergeUndoDeltas = true; appendLines(doc, "Error executing search: " + err.message); tab.classList.remove("loading"); tab.classList.add("error"); @@ -613,6 +615,7 @@ define(function(require, exports, module) { doc.ace.scrollToLine(currLength, false, true); firstRun = false; } + acesession.mergeUndoDeltas = true; appendLines(doc, reBase ? chunk.replace(reBase, "") : chunk); }); @@ -628,6 +631,7 @@ define(function(require, exports, module) { var line = doc.getLine(endRow - i); if (line && /Found \d+/.test(line)) { var headerRow = doc.lastHeaderRow; + acesession.mergeUndoDeltas = true; doc.insertInLine({ row: headerRow, column: doc.getLine(headerRow).length