Use less verbose `if` statements (#166)

pull/169/head
BO41 2018-08-04 13:55:37 +02:00 zatwierdzone przez Thomas Buckley-Houston
rodzic 99dcc23792
commit ad235b6c51
3 zmienionych plików z 1965 dodań i 1957 usunięć

Wyświetl plik

@ -2,7 +2,6 @@ package browsh
import (
"crypto/rand"
"sync"
"encoding/json"
"fmt"
"io"
@ -10,6 +9,7 @@ import (
"net/url"
"regexp"
"strings"
"sync"
"time"
"github.com/NYTimes/gziphandler"
@ -244,7 +244,7 @@ func waitForResponse(rawTextRequestID string, w http.ResponseWriter) {
for {
if rawTextRequestResponse, ok = rawTextRequests.load(rawTextRequestID); ok {
jsonResponse = unpackResponse(rawTextRequestResponse)
requestStart, _ := rawTextRequests.load(rawTextRequestID+"-start")
requestStart, _ := rawTextRequests.load(rawTextRequestID + "-start")
totalTime = getTotalTiming(requestStart)
pageLoad = fmt.Sprintf("%d", jsonResponse.PageloadDuration)
parsing = fmt.Sprintf("%d", jsonResponse.ParsingDuration)

3890
webext/package-lock.json wygenerowano

Plik diff jest za duży Load Diff

Wyświetl plik

@ -14,24 +14,18 @@ export default class extends utils.mixins(CommonMixin) {
// This used to be dynamically calculated at _calculateCharacterDimensions()
// But it proved to be bugy, I think because of a race condition on lightweight sites
// where the webextension's CSS wouldn't get applied in time.
if (!TEST) {
this._pre_calculated_char = {
width: 9,
height: 15
};
} else {
this._pre_calculated_char = {
width: 1,
height: 2
};
}
this._pre_calculated_char = !TEST
? {
width: 9,
height: 15
}
: {
width: 1,
height: 2
};
if (!TEST) {
// TODO: WTF is this magic number? The gap between lines?
this._char_height_magic_number = 5;
} else {
this._char_height_magic_number = 0;
}
// TODO: WTF is this magic number? The gap between lines?
this._char_height_magic_number = !TEST ? 5 : 0;
// This is the region outside the visible area of the TTY that is pre-parsed and
// sent to the TTY to be buffered to support faster scrolling.