From 243e28052e585a0d5f96b772f012b39b5689943d Mon Sep 17 00:00:00 2001
From: Ryan Barrett <git@ryanb.org>
Date: Tue, 20 Jun 2023 07:02:20 -0700
Subject: [PATCH] CI: catch redefined test methods with flake8

---
 .circleci/config.yml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index b07aabe..c7b3e11 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -28,7 +28,7 @@ jobs:
       - run:
           name: Python dependencies
           command: |
-            pip install -U pip
+            pip install -U pip flake8
             pip  -V
             # make sure we install these at head, below
             pip uninstall -y granary lexrpc oauth-dropins
@@ -47,6 +47,11 @@ jobs:
             python -m coverage html -d /tmp/coverage_html
             if [ "$COVERALLS_REPO_TOKEN" != "" ]; then coveralls || true; fi
 
+            # check for unintentionally overridden test methods
+            # https://flake8.pycqa.org/en/latest/user/error-codes.html#error-codes
+            # https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-select
+            flake8 --select=F811 tests/test_*.py
+
       # a step only runs if all previous steps succeed, including tests above
       # https://circleci.com/docs/configuration-reference/#the-when-attribute
       - run: